Clean up pref change notification handling.

chrome/browser/extensions/extension_prefs.cc

Index: chrome/browser/extensions/extension_prefs.cc
diff --git a/chrome/browser/extensions/extension_prefs.cc b/chrome/browser/extensions/extension_prefs.cc
index 07195e42e189765006377726e936e68b8426f145..653d2cd4ad9ab4a150b4218752793dba5825bf4c 100644
--- a/chrome/browser/extensions/extension_prefs.cc
+++ b/chrome/browser/extensions/extension_prefs.cc
@@ -326,7 +326,7 @@ void ExtensionPrefs::AddToExtensionPrefStringSet(
 
 void ExtensionPrefs::SavePrefsAndNotify() {
   prefs_->ScheduleSavePersistentPrefs();
-  prefs_->pref_notifier()->OnUserPreferenceSet(kExtensionsPref);
+  prefs_->pref_notifier()->OnPreferenceChanged(kExtensionsPref);

[battre (please use the other), 2010/12/02 10:41:19]

OnPreferenceChanged has the connotation that the preference value has actually
changed. Is that always the case here?

[Mattias Nissler (ping if slow), 2010/12/02 16:38:24]

You are right, that is not the case. However, the real problem is that we're
calling into pref_notifier() here, which we shouldn't. The correct way would be
to use something like ScopedPrefUpdate, but there are plans to upgrade this as
well. I put a TODO.

 }
 
 bool ExtensionPrefs::IsBlacklistBitSet(DictionaryValue* ext) {