Clean up pref change notification handling.

chrome/browser/extensions/extension_prefs.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_prefs.h"
 
 #include "base/string_util.h"
 #include "base/string_number_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/prefs/pref_notifier.h"
@@ skipping 308 matching lines @@
   for (std::set<std::string>::const_iterator iter = new_value.begin();
        iter != new_value.end(); ++iter)
     value->Append(Value::CreateStringValue(*iter));
 
   UpdateExtensionPref(extension_id, pref_key, value);
   prefs_->ScheduleSavePersistentPrefs();
 }
 
 void ExtensionPrefs::SavePrefsAndNotify() {
   prefs_->ScheduleSavePersistentPrefs();
-  prefs_->pref_notifier()->OnUserPreferenceSet(kExtensionsPref);
+  prefs_->pref_notifier()->OnPreferenceChanged(kExtensionsPref);

[battre (please use the other), 2010/12/02 10:41:19]

OnPreferenceChanged has the connotation that the preference value has actually
changed. Is that always the case here?

[Mattias Nissler (ping if slow), 2010/12/02 16:38:24]

You are right, that is not the case. However, the real problem is that we're
calling into pref_notifier() here, which we shouldn't. The correct way would be
to use something like ScopedPrefUpdate, but there are plans to upgrade this as
well. I put a TODO.

 }
 
 bool ExtensionPrefs::IsBlacklistBitSet(DictionaryValue* ext) {
   return ReadBooleanFromPref(ext, kPrefBlacklist);
 }
 
 bool ExtensionPrefs::IsExtensionBlacklisted(const std::string& extension_id) {
   return ReadExtensionPrefBoolean(extension_id, kPrefBlacklist);
 }
 
@@ skipping 754 matching lines @@
 void ExtensionPrefs::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterDictionaryPref(kExtensionsPref);
   prefs->RegisterListPref(kExtensionToolbar);
   prefs->RegisterIntegerPref(prefs::kExtensionToolbarSize, -1);
   prefs->RegisterDictionaryPref(kExtensionsBlacklistUpdate);
   prefs->RegisterListPref(prefs::kExtensionInstallAllowList);
   prefs->RegisterListPref(prefs::kExtensionInstallDenyList);
   prefs->RegisterListPref(prefs::kExtensionInstallForceList);
   prefs->RegisterStringPref(kWebStoreLogin, std::string() /* default_value */);
 }