Issue 543223: The FindMovesWhenObscuring test is still flaky on the builders. Marking it ac...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543223: The FindMovesWhenObscuring test is still flaky on the builders. Marking it ac... (Closed)

Created:
10 years, 11 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
Finnur

CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

The FindMovesWhenObscuring test is still flaky on the builders. Marking it accordingly. Bug=16447 TBR=finnur Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37226

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/views/find_bar_host_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Finnur

10 years, 11 months ago (2010-01-27 03:53:09 UTC) #2

So close... This shouldn't be too hard to fix though.

Looking...

Anyway, this change LGTM.

On Tue, Jan 26, 2010 at 19:25, <ananta@chromium.org> wrote:

> Reviewers: Finnur,
>
> Description:
> The FindMovesWhenObscuring test is still flaky on the builders. Marking it
> accordingly.
>
> Bug=16447
> TBR=finnur
>
>
> Please review this at http://codereview.chromium.org/543223
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     chrome/browser/views/find_bar_host_browsertest.cc
>
>
> Index: chrome/browser/views/find_bar_host_browsertest.cc
> ===================================================================
> --- chrome/browser/views/find_bar_host_browsertest.cc   (revision 37166)
> +++ chrome/browser/views/find_bar_host_browsertest.cc   (working copy)
> @@ -554,7 +554,8 @@
>  }
>
>  // Make sure Find box moves out of the way if it is obscuring the active
> match.
> -IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, FindMovesWhenObscuring) {
> +// Flaky, see http://crbug.com/16447.
> +IN_PROC_BROWSER_TEST_F(FindInPageControllerTest,
> FLAKY_FindMovesWhenObscuring) {
>   HTTPTestServer* server = StartHTTPServer();
>
>   GURL url = server->TestServerPageW(kMoveIfOver);
>
>
>

Expand Messages | Collapse Messages