Issue 5432002: Fix WorkerTest.WorkerWebSocketLayoutTests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5432002: Fix WorkerTest.WorkerWebSocketLayoutTests. (Closed)

Created:
10 years ago by Yuta Kitamura

Modified:
9 years, 7 months ago

Reviewers:
tyoshino (SeeGerritForStatus), ukai

CC:
chromium-reviews, jam, Paweł Hajdan Jr., Takashi Toyoshima (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix WorkerTest.WorkerWebSocketLayoutTests. The test now starts HTTPd along with the WebSocket server. Running both servers has become required because WebKit moved WebSocket tests under LayoutTests/http/ directory. BUG=49381 TEST=Run "ui_tests --gtest_filter=WorkerTest.WorkerWebSocketLayoutTests". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67946

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -15 lines)			Patch
	M	chrome/test/ui/ui_layout_test.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/worker/worker_uitest.cc	View		2 chunks	+12 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yuta Kitamura

Ukai-san, Yoshino-san: Could you review this? Toyoshima-san: FYI.

10 years ago (2010-12-01 07:08:29 UTC) #1

Yuta Kitamura

The test passed on all three platforms in the try runs. [ RUN ] WorkerTest.WorkerWebSocketLayoutTests ...

10 years ago (2010-12-01 07:59:21 UTC) #2

LGTM

Expand Messages | Collapse Messages