Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/worker/worker_uitest.cc

Issue 5432002: Fix WorkerTest.WorkerWebSocketLayoutTests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/ui/ui_layout_test.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/worker/worker_uitest.cc
diff --git a/chrome/worker/worker_uitest.cc b/chrome/worker/worker_uitest.cc
index 4b12a13be6b5302dcfd097f51a16853a15d3a199..6b788b57be8f30706f85af1af9bd22f2376919aa 100644
--- a/chrome/worker/worker_uitest.cc
+++ b/chrome/worker/worker_uitest.cc
@@ -445,8 +445,7 @@ TEST_F(WorkerTest, DISABLED_WorkerHttpLayoutTests) {
StopHttpServer();
}
-// Times out, see http://crbug.com/49381
-TEST_F(WorkerTest, DISABLED_WorkerWebSocketLayoutTests) {
+TEST_F(WorkerTest, WorkerWebSocketLayoutTests) {
static const char* kLayoutTestFiles[] = {
"close-in-onmessage-crash.html",
"close-in-shared-worker.html",
@@ -459,22 +458,21 @@ TEST_F(WorkerTest, DISABLED_WorkerWebSocketLayoutTests) {
FilePath websocket_test_dir;
websocket_test_dir = websocket_test_dir.AppendASCII("http");
websocket_test_dir = websocket_test_dir.AppendASCII("tests");
- websocket_test_dir = websocket_test_dir.AppendASCII("websocket");
- websocket_test_dir = websocket_test_dir.AppendASCII("tests");
FilePath worker_test_dir;
+ worker_test_dir = worker_test_dir.AppendASCII("websocket");
+ worker_test_dir = worker_test_dir.AppendASCII("tests");
worker_test_dir = worker_test_dir.AppendASCII("workers");
- InitializeForLayoutTest(websocket_test_dir, worker_test_dir, kWebSocketPort);
- test_case_dir_ = test_case_dir_.AppendASCII("http");
- test_case_dir_ = test_case_dir_.AppendASCII("tests");
- test_case_dir_ = test_case_dir_.AppendASCII("websocket");
- test_case_dir_ = test_case_dir_.AppendASCII("tests");
- test_case_dir_ = test_case_dir_.AppendASCII("workers");
-
- ui_test_utils::TestWebSocketServer websocket_server(
- temp_test_dir_.AppendASCII("LayoutTests"));
+ InitializeForLayoutTest(websocket_test_dir, worker_test_dir, kHttpPort);
+
+ FilePath websocket_root_dir(temp_test_dir_);
+ websocket_root_dir = websocket_root_dir.AppendASCII("LayoutTests");
+ ui_test_utils::TestWebSocketServer websocket_server(websocket_root_dir);
+
+ StartHttpServer(new_http_root_dir_);
for (size_t i = 0; i < arraysize(kLayoutTestFiles); ++i)
- RunLayoutTest(kLayoutTestFiles[i], kWebSocketPort);
+ RunLayoutTest(kLayoutTestFiles[i], kHttpPort);
+ StopHttpServer();
}
TEST_F(WorkerTest, DISABLED_WorkerXhrHttpLayoutTests) {
« no previous file with comments | « chrome/test/ui/ui_layout_test.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698