Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 543110: Created a base class for examples taken from gles2 book. It encapsulates the ... (Closed)

Created:
10 years, 11 months ago by alokp
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com, apatrick_chromium
Visibility:
Public.

Description

Created a base class for examples taken from gles2 book. It encapsulates the well-defined pattern followed by the examples to eliminate duplicated code. Once we finalize this CL, I will go ahead and change all demos to use this base class. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36542

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -49 lines) Patch
A gpu/demos/gles2_book/example.h View 1 1 chunk +75 lines, -0 lines 0 comments Download
M gpu/demos/hello_triangle/main.cc View 1 1 chunk +14 lines, -49 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alokp
10 years, 11 months ago (2010-01-19 05:38:48 UTC) #1
vangelis
Looks fine but out of curiosity, is there a good reason to template the functions? ...
10 years, 11 months ago (2010-01-19 18:00:48 UTC) #2
alokp
There are a couple of reasons I made the callback functions as templates. Most importantly ...
10 years, 11 months ago (2010-01-19 18:08:05 UTC) #3
vangelis
10 years, 11 months ago (2010-01-19 20:36:38 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698