Issue 543041: Remove a pair of problematic uses of the Reference utility class from...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 543041: Remove a pair of problematic uses of the Reference utility class from... (Closed)

Created:
10 years, 11 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Remove a pair of problematic uses of the Reference utility class from the code generators. These uses broke the rules of the class because it was safe to do so, but there was no real reason to do it that way. Committed: http://code.google.com/p/v8/source/detail?r=3598

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -98 lines)			Patch
M	src/arm/codegen-arm.cc	View	2 chunks	+21 lines, -25 lines	0 comments	Download
M	src/ast.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View	2 chunks	+28 lines, -35 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	2 chunks	+29 lines, -35 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages