Issue 542106: Add .so files ignored due to svn:ignore during http://codereview.chromium.org...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542106: Add .so files ignored due to svn:ignore during http://codereview.chromium.org... (Closed)

Created:
10 years, 11 months ago by Timur Iskhodzhanov

Modified:
9 years, 6 months ago

Reviewers:
Nicolas Sylvain, dank

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/

Visibility:
Public.

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)		Patch
A	deps/third_party/valgrind/binaries/linux_x86/lib/valgrind/vgpreload_core-x86-linux.so	View	Binary file	0 comments	Download
A	deps/third_party/valgrind/binaries/linux_x86/lib/valgrind/vgpreload_memcheck-x86-linux.so	View	Binary file	0 comments	Download
A	deps/third_party/valgrind/binaries/linux_x86/lib/valgrind/vgpreload_tsan-x86-linux.so	View	Binary file	0 comments	Download

Total messages: 3 (0 generated)

Nicolas Sylvain

10 years, 11 months ago (2010-01-18 21:46:14 UTC) #3

lg

On Mon, Jan 18, 2010 at 9:19 AM, <dank@chromium.org> wrote:

> LGTM
>
>
>
> http://codereview.chromium.org/542106
>