Issue 542078: Adding a secondary mini_installer target for Chrome Frame. This will remove t...

Issue 542078: Adding a secondary mini_installer target for Chrome Frame. This will remove t... (Closed)

Created:
10 years, 11 months ago by robertshield

Modified:
9 years, 6 months ago

Reviewers:
kuchhal, slightlyoff

CC:
chromium-reviews_googlegroups.com, kuchhal, amit, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adding a secondary mini_installer target for Chrome Frame. This will remove the need to have different build scripts to build either Chrome or Chrome Frame. Also remove the now-unneeded gyp variables 'chrome_frame_define' and 'google_update_appid'. BUG=Both Chrome and Chrome Frame products should be buildable from a single solution file - we shouldn't need to run GYP with different settings to get a CF solution. TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36546

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+315 lines, -284 lines)			Patch
M	app/app.gyp	View	1	1 chunk	+0 lines, -50 lines	0 comments	Download
M	build/all.gyp	View	1 2	4 chunks	+3 lines, -5 lines	0 comments	Download
M	build/common.gypi	View	1	2 chunks	+0 lines, -9 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1	3 chunks	+1 line, -16 lines	0 comments	Download
M	chrome/installer/installer.gyp	View	1 2 3 4 5	4 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/installer/installer_util.gypi	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/installer/mini_installer.gyp	View	1	2 chunks	+185 lines, -124 lines	0 comments	Download
A	chrome/installer/mini_installer/appid.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/installer/mini_installer/chrome.release	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
A	chrome/installer/mini_installer/chrome_appid.cc	View	4	1 chunk	+9 lines, -0 lines	0 comments	Download
A	chrome/installer/mini_installer/chrome_frame.release	View		1 chunk	+47 lines, -0 lines	0 comments	Download
A	chrome/installer/mini_installer/chrome_frame_appid.cc	View	4	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/installer/mini_installer/mini_installer.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/installer/setup/install.cc	View	1	2 chunks	+31 lines, -27 lines	0 comments	Download
M	chrome/tools/build/win/create_installer_archive.py	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		2 chunks	+2 lines, -3 lines	0 comments	Download
D	chrome_frame/rename_me_to_supplement.gypi	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

slightlyoff

LGTM. Nice to see the gyp time defines going away. Nice work.

10 years, 11 months ago (2010-01-14 22:47:26 UTC) #2

kuchhal

lgtm. Can you check if any changes are required on the Pulse builder due to ...

10 years, 11 months ago (2010-01-15 01:14:03 UTC) #3

robert

10 years, 11 months ago (2010-01-15 16:35:12 UTC) #4

Thanks!

On Thu, Jan 14, 2010 at 8:14 PM, <kuchhal@chromium.org> wrote:

> lgtm.
>
> Can you check if any changes are required on the Pulse builder due to this
> change?
>

This change requires a number of alterations (and hopefully,
simplifications) to the official build scripts (I'm working on those now
separately).

>
> http://codereview.chromium.org/542078
>

Expand Messages | Collapse Messages