Issue 542001: Fixes two fullscreen bugs on views/gtk:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 542001: Fixes two fullscreen bugs on views/gtk:... (Closed)

Created:
10 years, 11 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
oshima

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes two fullscreen bugs on views/gtk: . On X changing fullscreen is asynchronous. This means we have to ask the window to change it's fullscreen state, then once changed update the necessary things. . ExtensionShelf is needlessly triggering a bunch of layouts when we toggle fullscreen state. BUG=31143 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35905

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -74 lines)			Patch
M	chrome/browser/views/extensions/extension_shelf.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/views/frame/browser_frame_gtk.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/views/frame/browser_view.cc	View	3 chunks	+85 lines, -70 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

On 2010/01/09 00:03:33, sky wrote:
>

Expand Messages | Collapse Messages