Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: chrome/browser/views/frame/browser_view.h

Issue 542001: Fixes two fullscreen bugs on views/gtk:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 5 #ifndef CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
6 #define CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 6 #define CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 void AttachBrowserBubble(BrowserBubble *bubble); 206 void AttachBrowserBubble(BrowserBubble *bubble);
207 void DetachBrowserBubble(BrowserBubble *bubble); 207 void DetachBrowserBubble(BrowserBubble *bubble);
208 208
209 // Returns true if the specified point(BrowserView coordinates) is in 209 // Returns true if the specified point(BrowserView coordinates) is in
210 // in the window caption area of the browser window. 210 // in the window caption area of the browser window.
211 bool IsPositionInWindowCaption(const gfx::Point& point); 211 bool IsPositionInWindowCaption(const gfx::Point& point);
212 212
213 // Returns whether the fullscreen bubble is visible or not. 213 // Returns whether the fullscreen bubble is visible or not.
214 bool IsFullscreenBubbleVisible() const; 214 bool IsFullscreenBubbleVisible() const;
215 215
216 // Invoked from the frame when the full screen state changes. This is only
217 // used on Linux.
218 void FullScreenStateChanged();
219
216 // Overridden from BrowserWindow: 220 // Overridden from BrowserWindow:
217 virtual void Show(); 221 virtual void Show();
218 virtual void SetBounds(const gfx::Rect& bounds); 222 virtual void SetBounds(const gfx::Rect& bounds);
219 virtual void Close(); 223 virtual void Close();
220 virtual void Activate(); 224 virtual void Activate();
221 virtual bool IsActive() const; 225 virtual bool IsActive() const;
222 virtual void FlashFrame(); 226 virtual void FlashFrame();
223 virtual gfx::NativeWindow GetNativeHandle(); 227 virtual gfx::NativeWindow GetNativeHandle();
224 virtual BrowserWindowTesting* GetBrowserWindowTesting(); 228 virtual BrowserWindowTesting* GetBrowserWindowTesting();
225 virtual StatusBubble* GetStatusBubble(); 229 virtual StatusBubble* GetStatusBubble();
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 // removed. 414 // removed.
411 void UpdateUIForContents(TabContents* contents); 415 void UpdateUIForContents(TabContents* contents);
412 416
413 // Updates an optional child View, e.g. Bookmarks Bar, Info Bar, Download 417 // Updates an optional child View, e.g. Bookmarks Bar, Info Bar, Download
414 // Shelf. If |*old_view| differs from new_view, the old_view is removed and 418 // Shelf. If |*old_view| differs from new_view, the old_view is removed and
415 // the new_view is added. This is intended to be used when swapping in/out 419 // the new_view is added. This is intended to be used when swapping in/out
416 // child views that are referenced via a field. 420 // child views that are referenced via a field.
417 // Returns true if anything was changed, and a re-Layout is now required. 421 // Returns true if anything was changed, and a re-Layout is now required.
418 bool UpdateChildViewAndLayout(views::View* new_view, views::View** old_view); 422 bool UpdateChildViewAndLayout(views::View* new_view, views::View** old_view);
419 423
424 // Invoked to update the necessary things when our fullscreen state changes
425 // to |fullscreen|. On Windows this is invoked immediately when we toggle the
426 // full screen state. On Linux changing the fullscreen state is async, so we
427 // ask the window to change it's fullscreen state, then when we get
428 // notification that it succeeded this method is invoked.
429 void ProcessFullscreen(bool fullscreen);
430
420 // Copy the accelerator table from the app resources into something we can 431 // Copy the accelerator table from the app resources into something we can
421 // use. 432 // use.
422 void LoadAccelerators(); 433 void LoadAccelerators();
423 434
424 #if defined(OS_WIN) 435 #if defined(OS_WIN)
425 // Builds the correct menu for when we have minimal chrome. 436 // Builds the correct menu for when we have minimal chrome.
426 void BuildSystemMenuForBrowserWindow(); 437 void BuildSystemMenuForBrowserWindow();
427 void BuildSystemMenuForAppOrPopupWindow(bool is_app); 438 void BuildSystemMenuForAppOrPopupWindow(bool is_app);
428 #endif 439 #endif
429 440
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 561
551 scoped_ptr<BrowserExtender> browser_extender_; 562 scoped_ptr<BrowserExtender> browser_extender_;
552 563
553 // Last focused view that issued a tab traversal. 564 // Last focused view that issued a tab traversal.
554 int last_focused_view_storage_id_; 565 int last_focused_view_storage_id_;
555 566
556 DISALLOW_COPY_AND_ASSIGN(BrowserView); 567 DISALLOW_COPY_AND_ASSIGN(BrowserView);
557 }; 568 };
558 569
559 #endif // CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_ 570 #endif // CHROME_BROWSER_VIEWS_FRAME_BROWSER_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/views/frame/browser_frame_gtk.cc ('k') | chrome/browser/views/frame/browser_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698