Issue 541005: Mac: Connect "Task Manager" menu item.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 541005: Mac: Connect "Task Manager" menu item. (Closed)

Created:
10 years, 11 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Robert Sesek, viettrungluu

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Connect "Task Manager" menu item. Nib change: Connect "Task Manager" to first responder's commandDispatch:, give it tag 40005 (IDC_TASK_MANAGER in chrome/app/chrome_dll_resource.h), check "Enabled" checkbox (this has no effect, but is consistent with the rest of the nib). Due to http://codereview.chromium.org/518085 , the task manager is still disabled, but it's easier to turn on after this CL (only one small change in browser.cc). BUG=13156 TEST=Click View->Developer. "Task Manager" should still be disabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35878

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	chrome/app/nibs/MainMenu.xib	View		6 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

10 years, 11 months ago (2010-01-09 21:35:46 UTC) #2

LGTM (well, at least the description sounds okay). The diff looks okay too, as
okay as a diff of a xib can look at any rate.

Expand Messages | Collapse Messages