Mac: temporarily disable Full Screen and Task Manager.

Mac: temporarily disable Full Screen and Task Manager.

We need to do it in Browser, since the new common menu code (for the App and
Page menus) doesn't look to the BrowserWindowController for their enabled
status.

BUG=31768
TEST=On Mac, make sure the Full Screen and Task Manager menu items are disabled in both the main menu and in the App and Page menus. On other platforms, make sure they still work as usual.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35801

[viettrungluu, 2010-01-08 17:32:06]

Could you take a break from lifting weights (see, I do read my email!) and give
this a quick review?

[pink (ping after 24hrs), 2010-01-08 17:49:07]

LGTM

Can you add bug numbers to the TODOs for the bug that re-enables the feature for
each?

[viettrungluu, 2010-01-08 18:07:43]

All done.

@thakis: just a heads-up.

[Nico, 2010-01-08 23:08:04]

Thanks for the heads-up :-)

http://codereview.chromium.org/518085/diff/4001/5001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/518085/diff/4001/5001#newcode2486
chrome/browser/browser.cc:2486:
command_updater_.UpdateCommandEnabled(IDC_FULLSCREEN, true);
shouldn't this be "false"? also below.

(If not, the function has an odd name.)

[viettrungluu, 2010-01-08 23:09:58]

http://codereview.chromium.org/518085/diff/4001/5001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/518085/diff/4001/5001#newcode2486
chrome/browser/browser.cc:2486:
command_updater_.UpdateCommandEnabled(IDC_FULLSCREEN, true);
On 2010/01/08 23:08:04, Nico wrote:
> shouldn't this be "false"? also below.
> 
> (If not, the function has an odd name.)

It's an #ifndef. Commands are disabled by default.

[Nico, 2010-01-08 23:11:22]

http://codereview.chromium.org/518085/diff/4001/5001
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/518085/diff/4001/5001#newcode2486
chrome/browser/browser.cc:2486:
command_updater_.UpdateCommandEnabled(IDC_FULLSCREEN, true);
On 2010/01/08 23:09:58, viettrungluu wrote:
> On 2010/01/08 23:08:04, Nico wrote:
> > shouldn't this be "false"? also below.
> > 
> > (If not, the function has an odd name.)
> 
> It's an #ifndef. Commands are disabled by default.

doh. Carry on.