histogram API of WebKitClient implemented in chromium/webkit/glue

histogram API of WebKitClient implemented in chromium/webkit/glue

BUG=62865
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67920

[darin (slow to review), 2010-12-01 22:59:04]

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.cc
File webkit/glue/webkitclient_impl.cc (right):

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:263: base::Histogram::FactoryGet(name, min,
max, bucket_count,
nit: when breaking a line of code, we usually indent the continuation by 4
spaces relative to the previous line.

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:266: if (counter.get()) counter->Add(sample);
nit: please insert a new line so that it is possible to set a breakpoint on
"counter->Add(sample)"

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:273: scoped_refptr<base::Histogram> counter =
ditto

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:277: if (counter.get()) counter->Add(sample);
ditto

[scheib, 2010-12-01 23:28:59]

nits fixed. presuming lgtm.

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.cc
File webkit/glue/webkitclient_impl.cc (right):

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:263: base::Histogram::FactoryGet(name, min,
max, bucket_count,
On 2010/12/01 22:59:04, darin wrote:
> nit: when breaking a line of code, we usually indent the continuation by 4
> spaces relative to the previous line.

Done.

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:266: if (counter.get()) counter->Add(sample);
On 2010/12/01 22:59:04, darin wrote:
> nit: please insert a new line so that it is possible to set a breakpoint on
> "counter->Add(sample)"

Done.

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:273: scoped_refptr<base::Histogram> counter =
On 2010/12/01 22:59:04, darin wrote:
> ditto

Done.

http://codereview.chromium.org/5406004/diff/1/webkit/glue/webkitclient_impl.c...
webkit/glue/webkitclient_impl.cc:277: if (counter.get()) counter->Add(sample);
On 2010/12/01 22:59:04, darin wrote:
> ditto

Done.

[darin (slow to review), 2010-12-02 00:59:33]

LGTM