histogram API of WebKitClient implemented in chromium/webkit/glue

webkit/glue/webkitclient_impl.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/glue/webkitclient_impl.h"
 
 #if defined(OS_LINUX)
 #include <malloc.h>
 #endif
 
 #include <math.h>
 
 #include <vector>
 
 #include "base/debug/trace_event.h"
 #include "base/lock.h"
 #include "base/message_loop.h"
 #include "base/metrics/stats_counters.h"
+#include "base/metrics/histogram.h"
 #include "base/process_util.h"
 #include "base/platform_file.h"
 #include "base/singleton.h"
 #include "base/string_number_conversions.h"
 #include "base/string_util.h"
 #include "base/time.h"
 #include "base/utf_string_conversions.h"
 #include "grit/webkit_resources.h"
 #include "grit/webkit_strings.h"
 #include "third_party/WebKit/WebKit/chromium/public/WebCookie.h"
@@ skipping 218 matching lines @@
 }
 
 void WebKitClientImpl::decrementStatsCounter(const char* name) {
   base::StatsCounter(name).Decrement();
 }
 
 void WebKitClientImpl::incrementStatsCounter(const char* name) {
   base::StatsCounter(name).Increment();
 }
 
+void WebKitClientImpl::histogramCustomCounts(
+    const char* name, int sample, int min, int max, int bucket_count) {
+  // Copied from histogram macro, but without the static variable caching
+  // the histogram because name is dynamic.
+  scoped_refptr<base::Histogram> counter =
+    base::Histogram::FactoryGet(name, min, max, bucket_count,

[darin (slow to review), 2010/12/01 22:59:04]

nit: when breaking a line of code, we usually indent the continuation by 4
spaces relative to the previous line.

[scheib, 2010/12/01 23:28:59]

Done.

+      base::Histogram::kUmaTargetedHistogramFlag);
+  DCHECK_EQ(name, counter->histogram_name());
+  if (counter.get()) counter->Add(sample);

[darin (slow to review), 2010/12/01 22:59:04]

nit: please insert a new line so that it is possible to set a breakpoint on
"counter->Add(sample)"

[scheib, 2010/12/01 23:28:59]

Done.

+}
+
+void WebKitClientImpl::histogramEnumeration(
+    const char* name, int sample, int boundary_value) {
+  // Copied from histogram macro, but without the static variable caching
+  // the histogram because name is dynamic.
+  scoped_refptr<base::Histogram> counter =

[darin (slow to review), 2010/12/01 22:59:04]

ditto

[scheib, 2010/12/01 23:28:59]

Done.

+    base::LinearHistogram::FactoryGet(name, 1, boundary_value,
+      boundary_value + 1, base::Histogram::kUmaTargetedHistogramFlag);
+  DCHECK_EQ(name, counter->histogram_name());
+  if (counter.get()) counter->Add(sample);

[darin (slow to review), 2010/12/01 22:59:04]

ditto

[scheib, 2010/12/01 23:28:59]

Done.

+}
+
 void WebKitClientImpl::traceEventBegin(const char* name, void* id,
                                        const char* extra) {
   TRACE_EVENT_BEGIN(name, id, extra);
 }
 
 void WebKitClientImpl::traceEventEnd(const char* name, void* id,
                                      const char* extra) {
   TRACE_EVENT_END(name, id, extra);
 }
 
@@ skipping 236 matching lines @@
   ++shared_timer_suspended_;
 }
 
 void WebKitClientImpl::ResumeSharedTimer() {
   // The shared timer may have fired or been adjusted while we were suspended.
   if (--shared_timer_suspended_ == 0 && !shared_timer_.IsRunning())
     setSharedTimerFireTime(shared_timer_fire_time_);
 }
 
 }  // namespace webkit_glue