Support the PUT HTTP verb in ChromeFrame in the IE host network stack impleme...

Support the PUT HTTP verb in ChromeFrame in the IE host network stack implementation. This verb is supported
in the Chrome network stack. 

Added a urlrequest test for the HTTP PUT verb and corresponding support in the HTTP test server.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=31629

Bug=31629
Test=Covered by net tests.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35922

[wtc, 2010-01-09 00:58:28]

LGTM.

http://codereview.chromium.org/538012/diff/8003/8006
File chrome_frame/urlmon_url_request.cc (right):

http://codereview.chromium.org/538012/diff/8003/8006#newcode487
chrome_frame/urlmon_url_request.cc:487:
status_.set_os_error(net::ERR_INVALID_URL);
I think ERR_METHOD_NOT_SUPPORTED is a better error code
than ERR_INVALID_URL here.

http://codereview.chromium.org/538012/diff/8003/8006#newcode493
chrome_frame/urlmon_url_request.cc:493: // Bypass caching proxies on POSTs and
PUTs and avoid writing these
"these requests" => "responses to these requests"

http://codereview.chromium.org/538012/diff/8003/8006#newcode505
chrome_frame/urlmon_url_request.cc:505: DLOG(INFO) << " Obj: " << std::hex <<
this << " POST request with "
The DLOG messages on this line and line 508 below still refer
to "POST".  They need to be updated.

http://codereview.chromium.org/538012/diff/8003/8004
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/538012/diff/8003/8004#newcode1075
net/tools/testserver/testserver.py:1075: """Create directory named 'dump' where
uploaded data via HTTP POST request
This comment also mentions "POST".  Does it need to be
updated?  Just wondering...

http://codereview.chromium.org/538012/diff/8003/8005
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/538012/diff/8003/8005#newcode105
net/url_request/url_request_unittest.cc:105: void
HTTPUploadDataOperationTest(const char* method) {
Should we declare 'method' as const std::string& to be
more C++ compliant?

[ananta, 2010-01-09 15:57:26]

http://codereview.chromium.org/538012/diff/8003/8006
File chrome_frame/urlmon_url_request.cc (right):

http://codereview.chromium.org/538012/diff/8003/8006#newcode487
chrome_frame/urlmon_url_request.cc:487:
status_.set_os_error(net::ERR_INVALID_URL);
On 2010/01/09 00:58:28, wtc wrote:
> I think ERR_METHOD_NOT_SUPPORTED is a better error code
> than ERR_INVALID_URL here.

Done.

http://codereview.chromium.org/538012/diff/8003/8006#newcode493
chrome_frame/urlmon_url_request.cc:493: // Bypass caching proxies on POSTs and
PUTs and avoid writing these
On 2010/01/09 00:58:28, wtc wrote:
> "these requests" => "responses to these requests"

Done.

http://codereview.chromium.org/538012/diff/8003/8006#newcode505
chrome_frame/urlmon_url_request.cc:505: DLOG(INFO) << " Obj: " << std::hex <<
this << " POST request with "
On 2010/01/09 00:58:28, wtc wrote:
> The DLOG messages on this line and line 508 below still refer
> to "POST".  They need to be updated.

Done.

http://codereview.chromium.org/538012/diff/8003/8004
File net/tools/testserver/testserver.py (right):

http://codereview.chromium.org/538012/diff/8003/8004#newcode1075
net/tools/testserver/testserver.py:1075: """Create directory named 'dump' where
uploaded data via HTTP POST request
On 2010/01/09 00:58:28, wtc wrote:
> This comment also mentions "POST".  Does it need to be
> updated?  Just wondering...

Done.

http://codereview.chromium.org/538012/diff/8003/8005
File net/url_request/url_request_unittest.cc (right):

http://codereview.chromium.org/538012/diff/8003/8005#newcode105
net/url_request/url_request_unittest.cc:105: void
HTTPUploadDataOperationTest(const char* method) {
On 2010/01/09 00:58:28, wtc wrote:
> Should we declare 'method' as const std::string& to be
> more C++ compliant?

Done.

[amit, 2010-01-11 16:42:00]

lgtm

On Sat, Jan 9, 2010 at 7:57 AM,  <ananta@chromium.org> wrote:
>
> http://codereview.chromium.org/538012/diff/8003/8006
> File chrome_frame/urlmon_url_request.cc (right):
>
> http://codereview.chromium.org/538012/diff/8003/8006#newcode487
> chrome_frame/urlmon_url_request.cc:487:
> status_.set_os_error(net::ERR_INVALID_URL);
> On 2010/01/09 00:58:28, wtc wrote:
>>
>> I think ERR_METHOD_NOT_SUPPORTED is a better error code
>> than ERR_INVALID_URL here.
>
> Done.
>
> http://codereview.chromium.org/538012/diff/8003/8006#newcode493
> chrome_frame/urlmon_url_request.cc:493: // Bypass caching proxies on
> POSTs and PUTs and avoid writing these
> On 2010/01/09 00:58:28, wtc wrote:
>>
>> "these requests" => "responses to these requests"
>
> Done.
>
> http://codereview.chromium.org/538012/diff/8003/8006#newcode505
> chrome_frame/urlmon_url_request.cc:505: DLOG(INFO) << " Obj: " <<
> std::hex << this << " POST request with "
> On 2010/01/09 00:58:28, wtc wrote:
>>
>> The DLOG messages on this line and line 508 below still refer
>> to "POST".  They need to be updated.
>
> Done.
>
> http://codereview.chromium.org/538012/diff/8003/8004
> File net/tools/testserver/testserver.py (right):
>
> http://codereview.chromium.org/538012/diff/8003/8004#newcode1075
> net/tools/testserver/testserver.py:1075: """Create directory named
> 'dump' where uploaded data via HTTP POST request
> On 2010/01/09 00:58:28, wtc wrote:
>>
>> This comment also mentions "POST".  Does it need to be
>> updated?  Just wondering...
>
> Done.
>
> http://codereview.chromium.org/538012/diff/8003/8005
> File net/url_request/url_request_unittest.cc (right):
>
> http://codereview.chromium.org/538012/diff/8003/8005#newcode105
> net/url_request/url_request_unittest.cc:105: void
> HTTPUploadDataOperationTest(const char* method) {
> On 2010/01/09 00:58:28, wtc wrote:
>>
>> Should we declare 'method' as const std::string& to be
>> more C++ compliant?
>
> Done.
>
> http://codereview.chromium.org/538012
>