Issue 5361011: Revert r49502 (http://codereview.chromium.org/2796002), since we don't need a...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5361011: Revert r49502 (http://codereview.chromium.org/2796002), since we don't need a... (Closed)

Created:
10 years ago by jam

Modified:
9 years, 7 months ago

Reviewers:
tony, bradnelson, Evan Martin

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

linux: remove split base_extra_target from base.gyp Previously we built part of base twice under different configurations. This reverts r49502 (http://codereview.chromium.org/2796002), since we don't need a separate fpic base target now that all of Linux is built with fpic. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67893

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -232 lines)			Patch
	M	base/base.gypi	View		8 chunks	+166 lines, -232 lines	0 comments	Download

Total messages: 5 (0 generated)

jam

Marc-Antoine: can you take a look? Brad appears to be OOO, and the trybots are ...

10 years ago (2010-12-01 19:05:21 UTC) #2

LGTM