Issue 2796002: Build a version of base with -fPIC turned on. Use it for internal plugin. C...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2796002: Build a version of base with -fPIC turned on. Use it for internal plugin. C... (Closed)

Created:
10 years, 6 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Build a version of base with -fPIC turned on. Use it for internal plugin. Credit to bradnelson who did this. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49502

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+223 lines, -165 lines)			Patch
M	base/base.gypi	View	6 chunks	+217 lines, -165 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/chrome_exe.gypi	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

bradn

10 years, 6 months ago (2010-06-11 03:57:51 UTC) #2

LGTM (somewhat biased :-)
Do try to get a cleanish bounce off the trybots, as this has 'danger' potential.
Maybe kick off 1-2 with -c in fact.