Suppress crash dump generation due to IsBadXXX functions....

Suppress crash dump generation due to IsBadXXX functions.

IsBad[Read/Write]Ptr etc functions cause access violations
which we catch and take crash dump if we are on stack. Adding
code to suppress these false positives.

BUG=none
TEST=added new tests cases to ChromeFrame.ExceptionReport


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36403

[stoyan, 2010-01-15 17:14:28]

http://codereview.chromium.org/536073/diff/1/3
File chrome_frame/crash_reporting/vectored_handler-impl.h (right):

http://codereview.chromium.org/536073/diff/1/3#newcode73
chrome_frame/crash_reporting/vectored_handler-impl.h:73: if
(E::ShouldIgnoreException(address)) {
Pass exceptionInfo as argument instead? Decision whether to ignore exception can
be made based on specific exception code in specific memory range.

http://codereview.chromium.org/536073/diff/1/4
File chrome_frame/crash_reporting/vectored_handler.h (right):

http://codereview.chromium.org/536073/diff/1/4#newcode118
chrome_frame/crash_reporting/vectored_handler.h:118: }
Move the above code block to Win32VEHTraits.
Here only static inline bool ShouldIgnoreException() {return FALSE;} should
remain, since this is a minimal very base class.
Move the initialization steps somewhere in Win32VEHTraits::Register. Calling
GetModuleHandle/GetProcAddress (grabs loaderlock) in a VEH is not good.
Perhaps we also have to check for STATUS_ACCESS_VIOLATION exceptionCode? What if
we hit STATUS_ILLEGAL_INSTRUCTION in IsBadWritePtr? :)

[amit, 2010-01-15 20:03:30]

http://codereview.chromium.org/536073/diff/1/3
File chrome_frame/crash_reporting/vectored_handler-impl.h (right):

http://codereview.chromium.org/536073/diff/1/3#newcode73
chrome_frame/crash_reporting/vectored_handler-impl.h:73: if
(E::ShouldIgnoreException(address)) {
On 2010/01/15 17:14:28, stoyan wrote:
> Pass exceptionInfo as argument instead? Decision whether to ignore exception
can
> be made based on specific exception code in specific memory range.

Done.

http://codereview.chromium.org/536073/diff/1/4
File chrome_frame/crash_reporting/vectored_handler.h (right):

http://codereview.chromium.org/536073/diff/1/4#newcode118
chrome_frame/crash_reporting/vectored_handler.h:118: }
On 2010/01/15 17:14:28, stoyan wrote:
> Move the above code block to Win32VEHTraits.
> Here only static inline bool ShouldIgnoreException() {return FALSE;} should
> remain, since this is a minimal very base class.
> Move the initialization steps somewhere in Win32VEHTraits::Register. Calling
> GetModuleHandle/GetProcAddress (grabs loaderlock) in a VEH is not good.
> Perhaps we also have to check for STATUS_ACCESS_VIOLATION exceptionCode? What
if
> we hit STATUS_ILLEGAL_INSTRUCTION in IsBadWritePtr? :)
Good catch, moved.

[stoyan, 2010-01-15 20:23:01]

lg

http://codereview.chromium.org/536073/diff/5001/4006
File chrome_frame/crash_reporting/crash_report.h (right):

http://codereview.chromium.org/536073/diff/5001/4006#newcode77
chrome_frame/crash_reporting/crash_report.h:77: (CodeOffset(code_block.code,
code_block.begin_offset) < address) &&
<= address?