Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_frame/crash_reporting/vectored_handler-impl.h

Issue 536073: Suppress crash dump generation due to IsBadXXX functions.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome_frame/crash_reporting/crash_report.h ('K') | « chrome_frame/crash_reporting/vectored_handler.h ('k') | chrome_frame/crash_reporting/vectored_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/crash_reporting/vectored_handler-impl.h
===================================================================
--- chrome_frame/crash_reporting/vectored_handler-impl.h (revision 36161)
+++ chrome_frame/crash_reporting/vectored_handler-impl.h (working copy)
@@ -65,8 +65,11 @@
++VectoredHandlerT<E>::g_exceptions_seen;
- // TODO(stoyan): Check whether exception address is inbetween
+ // Check whether exception address is inbetween
// [IsBadReadPtr, IsBadReadPtr + 0xXX]
+ if (E::ShouldIgnoreException(exceptionInfo)) {
+ return ExceptionContinueSearch;
+ }
const DWORD exceptionFlags = exceptionInfo->ExceptionRecord->ExceptionFlags;
// I don't think VEH is called on unwind. Just to be safe.
« chrome_frame/crash_reporting/crash_report.h ('K') | « chrome_frame/crash_reporting/vectored_handler.h ('k') | chrome_frame/crash_reporting/vectored_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698