GTK: Store the contents of the clipboard to the clipboard manager on exit.

GTK: Store the contents of the clipboard to the clipboard manager on exit.

BUG=21744
TEST=Copy text from a webpage. Paste it into gedit. Close chrome. You should still be able to paste into gedit.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67782

[Elliot Glaysher, 2010-11-30 18:37:10]

I didn't notice any performance downsides while investigating this.

[Evan Stade, 2010-11-30 21:37:10]

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.cc
File app/clipboard/clipboard_linux.cc (right):

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.c...
app/clipboard/clipboard_linux.cc:104: gtk_clipboard_store(clipboard_);
shouldn't we only call this if we own the clipboard?

[Elliot Glaysher, 2010-11-30 21:50:29]

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.cc
File app/clipboard/clipboard_linux.cc (right):

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.c...
app/clipboard/clipboard_linux.cc:104: gtk_clipboard_store(clipboard_);
On 2010/11/30 21:37:11, Evan Stade wrote:
> shouldn't we only call this if we own the clipboard?

I'm not sure I understand. What does that mean and how would I check for it?

[Elliot Glaysher, 2010-11-30 22:03:36]

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.cc
File app/clipboard/clipboard_linux.cc (right):

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.c...
app/clipboard/clipboard_linux.cc:104: gtk_clipboard_store(clipboard_);
On 2010/11/30 21:37:11, Evan Stade wrote:
> shouldn't we only call this if we own the clipboard?

OK, I don't think so. I did the following test:

- Copy text in chrome
- Paste text in gedit.
- Copy text from terminal.
- Close chrome
- Paste text in gedit. It was the terminal text.

I think gtk_clipboard_store() is checking to make sure we don't clobber when we
don't own the clipboard.

[Evan Stade, 2010-11-30 22:05:00]

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.cc
File app/clipboard/clipboard_linux.cc (right):

http://codereview.chromium.org/5357011/diff/1/app/clipboard/clipboard_linux.c...
app/clipboard/clipboard_linux.cc:104: gtk_clipboard_store(clipboard_);
On 2010/11/30 21:50:29, Elliot Glaysher wrote:
> On 2010/11/30 21:37:11, Evan Stade wrote:
> > shouldn't we only call this if we own the clipboard?
> 
> I'm not sure I understand. What does that mean and how would I check for it?

actually, this might not be the right place to call this as the clipboard
ownership timeline doesn't seem to be tied to the Clipboard object's lifetime.

Is it necessary at all to call this? The docs seem to state it will
automatically be called when the app exits.

[Elliot Glaysher, 2010-11-30 22:11:08]

On 2010/11/30 22:05:00, Evan Stade wrote:
> Is it necessary at all to call this? The docs seem to state it will
> automatically be called when the app exits.

Yes. After removing it, this doesn't work anymore.

[Evan Stade, 2010-11-30 22:51:29]

ok, lgtm

-- Evan Stade


On Tue, Nov 30, 2010 at 2:11 PM, <erg@chromium.org> wrote:

> On 2010/11/30 22:05:00, Evan Stade wrote:
>
>> Is it necessary at all to call this? The docs seem to state it will
>> automatically be called when the app exits.
>>
>
> Yes. After removing it, this doesn't work anymore.
>
>
> http://codereview.chromium.org/5357011/
>