GTK: Store the contents of the clipboard to the clipboard manager on exit.

app/clipboard/clipboard_linux.cc

Index: app/clipboard/clipboard_linux.cc
diff --git a/app/clipboard/clipboard_linux.cc b/app/clipboard/clipboard_linux.cc
index 4c833fb6a7ed6a96b656a5c6ac73ac205536f2fb..8408614e53b7518a71138c5ade047f3cb613980e 100644
--- a/app/clipboard/clipboard_linux.cc
+++ b/app/clipboard/clipboard_linux.cc
@@ -101,9 +101,7 @@ Clipboard::Clipboard() : clipboard_data_(NULL) {
 }
 
 Clipboard::~Clipboard() {
-  // TODO(estade): do we want to save clipboard data after we exit?
-  // gtk_clipboard_set_can_store and gtk_clipboard_store work
-  // but have strangely awful performance.
+  gtk_clipboard_store(clipboard_);

[Evan Stade, 2010/11/30 21:37:11]

shouldn't we only call this if we own the clipboard?

[Elliot Glaysher, 2010/11/30 21:50:29]

I'm not sure I understand. What does that mean and how would I check for it?

[Elliot Glaysher, 2010/11/30 22:03:36]

OK, I don't think so. I did the following test:

- Copy text in chrome
- Paste text in gedit.
- Copy text from terminal.
- Close chrome
- Paste text in gedit. It was the terminal text.

I think gtk_clipboard_store() is checking to make sure we don't clobber when we
don't own the clipboard.

[Evan Stade, 2010/11/30 22:05:00]

actually, this might not be the right place to call this as the clipboard
ownership timeline doesn't seem to be tied to the Clipboard object's lifetime.

Is it necessary at all to call this? The docs seem to state it will
automatically be called when the app exits.

 }
 
 void Clipboard::WriteObjects(const ObjectMap& objects) {
@@ -138,10 +136,14 @@ void Clipboard::SetGtkClipboard() {
     targets[i].info = 0;
   }
 
-  gtk_clipboard_set_with_data(clipboard_, targets.get(),
-                              clipboard_data_->size(),
-                              GetData, ClearData,
-                              clipboard_data_);
+  if (gtk_clipboard_set_with_data(clipboard_, targets.get(),
+                                  clipboard_data_->size(),
+                                  GetData, ClearData,
+                                  clipboard_data_)) {
+    gtk_clipboard_set_can_store(clipboard_,
+                                targets.get(),
+                                clipboard_data_->size());
+  }
 
   // clipboard_data_ now owned by the GtkClipboard.
   clipboard_data_ = NULL;