Device management constants cleanup

Device management constants cleanup

• Move device management protocol constants into shared header file
• Filter out policies with unwanted keys when decoding server response

This also fixes bug 62058.

BUG=62481
TEST=existing unit tests still work: DeviceManagementPolicyProviderTest.*:DeviceTokenFetcherTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67259

[Jakob Kummerow, 2010-11-23 18:29:40]

Here you go, please review. 
I hope that I found all hardcoded occurrences of the string constants, but since
I grepped for likely candidates in chrome/browser/policy/* I'm relatively
confident that this is the case.

[danno, 2010-11-24 09:50:50]

looks like device_management_constants.h/cc are missing from the CL?

[danno, 2010-11-24 10:20:42]

One nit + try bots seem to have surfaced real failures related to this change.

http://codereview.chromium.org/5348001/diff/4001/chrome/browser/policy/proto/...
File chrome/browser/policy/proto/device_management_constants.h (right):

http://codereview.chromium.org/5348001/diff/4001/chrome/browser/policy/proto/...
chrome/browser/policy/proto/device_management_constants.h:15: #endif /*
CHROME_BROWSER_POLICY_PROTO_DEVICE_MANAGEMENT_CONSTANTS_H_ */
nit: two spaces after #endif, and usually I've seen //-style comments.

[Jakob Kummerow, 2010-11-24 10:35:51]

Fixed nit. 
Also fixed those unit tests (I had missed an occurrence of the policy_key).

http://codereview.chromium.org/5348001/diff/4001/chrome/browser/policy/proto/...
File chrome/browser/policy/proto/device_management_constants.h (right):

http://codereview.chromium.org/5348001/diff/4001/chrome/browser/policy/proto/...
chrome/browser/policy/proto/device_management_constants.h:15: #endif /*
CHROME_BROWSER_POLICY_PROTO_DEVICE_MANAGEMENT_CONSTANTS_H_ */
On 2010/11/24 10:20:42, danno wrote:
> nit: two spaces after #endif, and usually I've seen //-style comments.

Done.

[danno, 2010-11-24 10:54:17]

LGTM pending green trybots