Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1869)

Unified Diff: chrome/browser/policy/device_management_service_browsertest.cc

Issue 5348001: Device management constants cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix nit; fix DMPolicyCache unit tests Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/device_management_service_browsertest.cc
diff --git a/chrome/browser/policy/device_management_service_browsertest.cc b/chrome/browser/policy/device_management_service_browsertest.cc
index 70a8e1bd09c0d052b5a19c92224fd1bf6b6d6eb0..6c07e9ef370ebe83620eda7b4376fdd90eacf1d8 100644
--- a/chrome/browser/policy/device_management_service_browsertest.cc
+++ b/chrome/browser/policy/device_management_service_browsertest.cc
@@ -6,6 +6,7 @@
#include "chrome/browser/browser_thread.h"
#include "chrome/browser/policy/device_management_backend_mock.h"
#include "chrome/browser/policy/device_management_service.h"
+#include "chrome/browser/policy/proto/device_management_constants.h"
#include "chrome/browser/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/in_process_browser_test.h"
@@ -114,10 +115,10 @@ IN_PROC_BROWSER_TEST_F(DeviceManagementServiceIntegrationTest,
EXPECT_CALL(delegate, HandlePolicyResponse(_))
.WillOnce(InvokeWithoutArgs(QuitMessageLoop));
em::DevicePolicyRequest request;
- request.set_policy_scope("chrome");
+ request.set_policy_scope(kChromePolicyScope);
em::DevicePolicySettingRequest* setting_request =
request.add_setting_request();
- setting_request->set_key("policy");
+ setting_request->set_key(kChromeDevicePolicySettingKey);
backend->ProcessPolicyRequest(token_, "testid", request, &delegate);
MessageLoop::current()->Run();
@@ -165,10 +166,10 @@ IN_PROC_BROWSER_TEST_F(DeviceManagementServiceIntegrationTest,
EXPECT_CALL(delegate, HandlePolicyResponse(_))
.WillOnce(InvokeWithoutArgs(QuitMessageLoop));
em::DevicePolicyRequest request;
- request.set_policy_scope("chrome");
+ request.set_policy_scope(kChromePolicyScope);
em::DevicePolicySettingRequest* setting_request =
request.add_setting_request();
- setting_request->set_key("policy");
+ setting_request->set_key(kChromeDevicePolicySettingKey);
backend->ProcessPolicyRequest(token_, "testid", request, &delegate);
MessageLoop::current()->Run();

Powered by Google App Engine
This is Rietveld 408576698