NTP update for ChromeOS.

NTP update for ChromeOS.

- Default to show expanded apps (i.e. most visited and recently closed
  secion is closed by default);
- Move closed section bar up to underneath the expanded sections;
- Add a seprate line between expanded and closed section bar;
- Change the closed section menu footer text to "Expand"

BUG=chromium-os:9737
TEST=Verify fix for chromium-os:9737 and no change to non chrome os version.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67736

[xiyuan, 2010-11-30 16:52:33]

This is one of the last bits for R9.x. Please review. Thanks.

[Aaron Boodman, 2010-11-30 18:38:32]

It is a bit abnormal to modify the ntp for only chrome os. As long as the UI
leads are OK with it, lgtm w/ nits.

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.html:290: </script>
It's a little odd to have separate script blocks like this. Can you combine all
three of these blocks?

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.js:78:
localStrings.getString('expandMenu');
This can fit on the previous line.

[xiyuan, 2010-11-30 19:07:58]

All nits fixed.

Yeah, I do not like to special-case ChromeOs either. :(

This comes from Kan and there is a "UI polishment for ChromeOS" discussion about
it and I think this is the final agreement from the PM and UI leads.

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.html:290: </script>
On 2010/11/30 18:38:32, Aaron Boodman wrote:
> It's a little odd to have separate script blocks like this. Can you combine
all
> three of these blocks?

Done.

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.js (right):

http://codereview.chromium.org/5340007/diff/4001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.js:78:
localStrings.getString('expandMenu');
On 2010/11/30 18:38:32, Aaron Boodman wrote:
> This can fit on the previous line.

Done.

[Aaron Boodman, 2010-11-30 19:10:25]

lgtm

[Dmitry Polukhin, 2010-11-30 20:06:55]

FYI

http://codereview.chromium.org/5340007/diff/7002/chrome/browser/dom_ui/shown_...
File chrome/browser/dom_ui/shown_sections_handler.cc (right):

http://codereview.chromium.org/5340007/diff/7002/chrome/browser/dom_ui/shown_...
chrome/browser/dom_ui/shown_sections_handler.cc:99: APPS | MINIMIZED_THUMB |
MINIMIZED_RECENT);
I think if no app are installed, it will show all sections closed. Apps section
should be opened if you have at least one app installed due to my change CL
http://codereview.chromium.org/4885001