base/scoped_temp_dir.h - Issue 5340004: Make ScopedTempDir::Delete return a bool so that its functionality can be te...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/scoped_temp_dir.h

Issue 5340004: Make ScopedTempDir::Delete return a bool so that its functionality can be te... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/scoped_temp_dir.h

===================================================================

--- base/scoped_temp_dir.h (revision 67430)

+++ base/scoped_temp_dir.h (working copy)

@@ -38,7 +38,10 @@

bool Set(const FilePath& path);

// Deletes the temporary directory wrapped by this object.

- void Delete();

+ // Returns true if the directory was successfully deleted.

+ // If the current path is empty or if the folder can't be deleted

Paweł Hajdan Jr. 2010/11/26 21:01:20 nit: Don't mention all failure cases. I guess even

+ // for some reason, the return value is false.

+ bool Delete();

Paweł Hajdan Jr. 2010/11/26 21:01:20 nit: Add WARN_UNUSED_RESULT from base/compiler_spe

// Caller takes ownership of the temporary directory so it won't be destroyed

// when this object goes out of scope.

« no previous file with comments | « no previous file | base/scoped_temp_dir.cc » ('j') | base/scoped_temp_dir.cc » ('J')