Make ScopedTempDir::Delete return a bool so that its functionality can be te...

base/scoped_temp_dir.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_SCOPED_TEMP_DIR_H_
 #define BASE_SCOPED_TEMP_DIR_H_
 #pragma once
 
 // An object representing a temporary / scratch directory that should be cleaned
 // up (recursively) when this object goes out of scope.  Note that since
@@ skipping 20 matching lines @@
   bool CreateUniqueTempDir();
 
   // Creates a unique directory under a given path, and takes ownership of it.
   bool CreateUniqueTempDirUnderPath(const FilePath& path);
 
   // Takes ownership of directory at |path|, creating it if necessary.
   // Don't call multiple times unless Take() has been called first.
   bool Set(const FilePath& path);
 
   // Deletes the temporary directory wrapped by this object.
-  void Delete();
+  // Returns true if the directory was successfully deleted.
+  // If the current path is empty or if the folder can't be deleted

[Paweł Hajdan Jr., 2010/11/26 21:01:20]

nit: Don't mention all failure cases. I guess even now the list isn't
exhaustive.

+  // for some reason, the return value is false.
+  bool Delete();

[Paweł Hajdan Jr., 2010/11/26 21:01:20]

nit: Add WARN_UNUSED_RESULT from base/compiler_specific.

 
   // Caller takes ownership of the temporary directory so it won't be destroyed
   // when this object goes out of scope.
   FilePath Take();
 
   const FilePath& path() const { return path_; }
 
   // Returns true if path_ is non-empty and exists.
   bool IsValid() const;
 
  private:
   FilePath path_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedTempDir);
 };
 
 #endif  // BASE_SCOPED_TEMP_DIR_H_