Check that TabContents is valid (not null) before removing theme change InfoBar.

Check that TabContents is valid (not null) before removing theme change InfoBar.

BUG=60761
TEST=interactive_ui_tests and repro steps in bug

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68112

[Tessa MacDuff, 2010-11-30 22:23:41]

One more attempt to fix the theme-change crashing bug.

[Aaron Boodman, 2010-12-01 01:06:05]

lgtm

http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme...
File chrome/browser/extensions/theme_installed_infobar_delegate.cc (right):

http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme...
chrome/browser/extensions/theme_installed_infobar_delegate.cc:107: // it is
still needed if we "undo" the theme change that triggered
I think it would probably be good to reference the bug that peter is working on
here and explain why we can't just delete ourselves here.

[Tessa MacDuff, 2010-12-01 19:16:37]

and uploaded

http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme...
File chrome/browser/extensions/theme_installed_infobar_delegate.cc (right):

http://codereview.chromium.org/5326011/diff/1/chrome/browser/extensions/theme...
chrome/browser/extensions/theme_installed_infobar_delegate.cc:107: // it is
still needed if we "undo" the theme change that triggered
On 2010/12/01 01:06:06, Aaron Boodman wrote:
> I think it would probably be good to reference the bug that peter is working
on
> here and explain why we can't just delete ourselves here.

Done.

[Aaron Boodman, 2010-12-02 20:34:03]

Thanks, still lg