chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc - Issue 5318002: Also register read cookies in the content settings delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

Issue 5318002: Also register read cookies in the content settings delegate. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/render_view_host_delegate.h ('K') | « chrome/browser/tab_contents/tab_specific_content_settings.cc ('k') | net/base/cookie_monster.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

diff --git a/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc b/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

index 5be081cd417ac78e9ab1d78314ef8bb3a46b11c7..d23d877a62eafa2c28711e53e56690d9c50eef50 100644

--- a/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

+++ b/chrome/browser/tab_contents/tab_specific_content_settings_unittest.cc

@@ -53,7 +53,7 @@ TEST(TabSpecificContentSettingsTest, BlockedContent) {

EXPECT_FALSE(content_settings.IsContentBlocked(CONTENT_SETTINGS_TYPE_POPUPS));

// Set a cookie, block access to images, block a popup.

- content_settings.OnCookieAccessed(

+ content_settings.OnCookieChanged(

GURL("http://google.com"), "A=B", options, false);

EXPECT_TRUE(test_delegate.SettingsChanged());

EXPECT_FALSE(test_delegate.ContentBlocked());

@@ -77,11 +77,11 @@ TEST(TabSpecificContentSettingsTest, BlockedContent) {

EXPECT_FALSE(

content_settings.IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));

EXPECT_TRUE(content_settings.IsContentBlocked(CONTENT_SETTINGS_TYPE_POPUPS));

- content_settings.OnCookieAccessed(

+ content_settings.OnCookieChanged(

GURL("http://google.com"), "A=B", options, false);

// Block a cookie.

- content_settings.OnCookieAccessed(

+ content_settings.OnCookieChanged(

GURL("http://google.com"), "C=D", options, true);

EXPECT_TRUE(

content_settings.IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));

@@ -124,13 +124,13 @@ TEST(TabSpecificContentSettingsTest, AllowedContent) {

content_settings.IsContentAccessed(CONTENT_SETTINGS_TYPE_COOKIES));

ASSERT_FALSE(

content_settings.IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));

- content_settings.OnCookieAccessed(

+ content_settings.OnCookieChanged(

GURL("http://google.com"), "A=B", options, false);

ASSERT_TRUE(

content_settings.IsContentAccessed(CONTENT_SETTINGS_TYPE_COOKIES));

ASSERT_FALSE(

content_settings.IsContentBlocked(CONTENT_SETTINGS_TYPE_COOKIES));

- content_settings.OnCookieAccessed(

+ content_settings.OnCookieChanged(

GURL("http://google.com"), "C=D", options, true);

ASSERT_TRUE(

content_settings.IsContentAccessed(CONTENT_SETTINGS_TYPE_COOKIES));