 Chromium Code Reviews
 Chromium Code Reviews Issue 5318002:
  Also register read cookies in the content settings delegate.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 5318002:
  Also register read cookies in the content settings delegate.  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: chrome/browser/renderer_host/render_view_host_delegate.h | 
| diff --git a/chrome/browser/renderer_host/render_view_host_delegate.h b/chrome/browser/renderer_host/render_view_host_delegate.h | 
| index e7f68e097c5bcd1a934596eab877c7079d9ce896..989364cb5b537456873612ae6d3b698c16044d8f 100644 | 
| --- a/chrome/browser/renderer_host/render_view_host_delegate.h | 
| +++ b/chrome/browser/renderer_host/render_view_host_delegate.h | 
| @@ -71,6 +71,7 @@ class Message; | 
| } | 
| namespace net { | 
| +class CookieList; | 
| class CookieOptions; | 
| } | 
| @@ -395,14 +396,23 @@ class RenderViewHostDelegate { | 
| virtual void OnContentBlocked(ContentSettingsType type, | 
| const std::string& resource_identifier) = 0; | 
| - // Called when a specific cookie in the current page was accessed. | 
| + // Called when cookies for given URL were read either from within the | 
| 
darin (slow to review)
2010/12/06 22:55:03
nit: "for given URL" -> "for the given URL"
 | 
| + // current page or while loading it. |blocked_by_policy| should be true, if | 
| + // reading cookies was blocked due to the user's content settings. In that | 
| + // case, this function should invoke OnContentBlocked. | 
| + virtual void OnCookiesRead( | 
| + const GURL& url, | 
| + const net::CookieList& cookie_list, | 
| + bool blocked_by_policy) = 0; | 
| + | 
| + // Called when a specific cookie in the current page was changed. | 
| // |blocked_by_policy| should be true, if the cookie was blocked due to the | 
| // user's content settings. In that case, this function should invoke | 
| // OnContentBlocked. | 
| - virtual void OnCookieAccessed(const GURL& url, | 
| - const std::string& cookie_line, | 
| - const net::CookieOptions& options, | 
| - bool blocked_by_policy) = 0; | 
| + virtual void OnCookieChanged(const GURL& url, | 
| + const std::string& cookie_line, | 
| + const net::CookieOptions& options, | 
| + bool blocked_by_policy) = 0; | 
| // Called when a specific indexed db factory in the current page was | 
| // accessed. If access was blocked due to the user's content settings, |