Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 5308005: crosutils: Use upstream dump_syms parameters for supporting splitdebug (Closed)

Created:
10 years ago by kmixter1
Modified:
9 years, 7 months ago
Reviewers:
petkov
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

crosutils: Use upstream dump_syms parameters for supporting splitdebug Change-Id: If4eba8779496c4fb0283865da48ba38941de9c08 BUG=9281 TEST=ran without obvious errors Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=2fb9892

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M cros_generate_breakpad_symbols View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kmixter1
10 years ago (2010-11-30 21:08:53 UTC) #1
petkov
So dump_syms is smart enough to distinguish between two file parameters vs. file+directory? Either way, ...
10 years ago (2010-11-30 21:16:10 UTC) #2
kmixter1
The upstream version only supports file+directory. Our branch didn't have splitdebug support and so I ...
10 years ago (2010-11-30 22:29:10 UTC) #3
kmixter1
The upstream version only supports file+directory. Our branch didn't have splitdebug support and so I ...
10 years ago (2010-11-30 22:39:08 UTC) #4
kmixter1
10 years ago (2010-12-06 19:06:39 UTC) #5
The upstream version only supports file+directory.  Our branch didn't
have splitdebug support and so I added it and I had the file+file
parameters.  Now I removed all our branched code and now we only pass
file+directory with this script.

On Tue, Nov 30, 2010 at 1:16 PM,  <petkov@chromium.org> wrote:
> So dump_syms is smart enough to distinguish between two file parameters vs.
> file+directory? Either way, it seems you've tested -- LGTM
>
>
> http://codereview.chromium.org/5308005/
>

Powered by Google App Engine
This is Rietveld 408576698