Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: cros_generate_breakpad_symbols

Issue 5308005: crosutils: Use upstream dump_syms parameters for supporting splitdebug (Closed) Base URL: http://git.chromium.org/git/crosutils.git@master
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cros_generate_breakpad_symbols
diff --git a/cros_generate_breakpad_symbols b/cros_generate_breakpad_symbols
index cee8731260d8a45d1a08917ad202e21971116fc7..8bfe8792c84bb97350736ed8c6b1d065e1e4e14b 100755
--- a/cros_generate_breakpad_symbols
+++ b/cros_generate_breakpad_symbols
@@ -77,11 +77,12 @@ function verify_not_64b_elf() {
function dump_file() {
local debug_file="$1"
local text_file="$2"
+ local debug_directory="$(dirname "${debug_file}")"
# 64b ELF files may be installed on the target in PERL directories
verify_not_64b_elf "${debug_file}" || return 1
verify_not_64b_elf "${text_file}" || return 1
# Dump symbols as root in order to read all files.
- if ! sudo "${DUMP_SYMS}" "${debug_file}" "${text_file}" > "${SYM_FILE}" \
+ if ! sudo "${DUMP_SYMS}" "${text_file}" "${debug_directory}" > "${SYM_FILE}" \
2> "${ERR_FILE}"; then
# A lot of files (like kernel files) contain no debug information, do
# not consider such occurrences as errors.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698