First stab at Mac breakpad support.

First stab at Mac breakpad support.
breakpad_mac.mm still needs some work, there's a bunch of scaffolding in there referring to a custom version of Breakpad I've got going locally.

[jeremy, 2009-03-25 23:14:27]

This code runs against a custom version of Breakpad I've compiled on my machine
(which just has a simple obj-c interface).

This code will just return silently in the current codebase.

The plan is to iterate using this interface till we get breakpad for osx
compiling in the tree then remove the scaffolding.

[John Grabowski, 2009-03-25 23:47:03]

LGTM with minor nits.
Great to see this coming together.

http://codereview.chromium.org/53075/diff/1/3
File chrome/app/breakpad.cc (left):

http://codereview.chromium.org/53075/diff/1/3#oldcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
ditto on rietveld vs svn

http://codereview.chromium.org/53075/diff/1/4
File chrome/app/breakpad.h (left):

http://codereview.chromium.org/53075/diff/1/4#oldcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
Presumably this is really an svn D, not a M, and rietveld just got confused?
Please dbl-check this was svn deleted.

http://codereview.chromium.org/53075/diff/1/6
File chrome/app/breakpad_mac.mm (right):

http://codereview.chromium.org/53075/diff/1/6#newcode14
Line 14: // TODO(playmobil): Remove this block once we include the breakpad
sources
s/playmobil/jeremy/g  (a few spots in here)

http://codereview.chromium.org/53075/diff/1/6#newcode17
Line 17: +(void*) Create:(NSDictionary*) parameters;
no space between (void*) and Create:.
Ditto line below.
Same thing for space between (NSDictionary*) and parameters.
I think the style guide supports this.

http://codereview.chromium.org/53075/diff/1/6#newcode29
Line 29: bool IsUsageReportingAllowed() {
Not clear what the purpose of this is?

http://codereview.chromium.org/53075/diff/1/6#newcode62
Line 62: NSString* breakpadBundlePath =  [[main_bundle privateFrameworksPath]
extra space between = and [[main_bundle

http://codereview.chromium.org/53075/diff/1/7
File chrome/app/breakpad_win.cc (right):

http://codereview.chromium.org/53075/diff/1/7#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
Presumably this is also an svn rename messed up by rietveld?

http://codereview.chromium.org/53075/diff/1/8
File chrome/app/breakpad_win.h (right):

http://codereview.chromium.org/53075/diff/1/8#newcode13
Line 13: void InitCrashReporter(const std::wstring& dll_path);
It's a little awkward to have C functions with the same name but different args
on Mac/Win.  Can we rename this one (e.g. InitCrashReporterWithDllPath())?

http://codereview.chromium.org/53075/diff/1/13
File chrome/chrome.gyp (right):

http://codereview.chromium.org/53075/diff/1/13#newcode1469
Line 1469: 'app/breakpad_win.cc',
Adding a comment (e.g. "see target_defaults above for info on which files get
magically removed from certain builds") might be nice.  Magic bad.