Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: base/logging.cc

Issue 53075: First stab at Mac breakpad support. (Closed)
Patch Set: Address John's comments Created 11 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/breakpad.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index 11dfe5db635489372586dd401857a448562a3d8d..41a0933d9933c17a77c9abe323d522b76e4dd744 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -525,8 +525,6 @@ LogMessage::~LogMessage() {
#endif
// Crash the process to generate a dump.
DebugUtil::BreakDebugger();
- // TODO(mmentovai): when we have breakpad support, generate a breakpad
- // dump, but until then, do not invoke the Apple crash reporter.
}
}
} else if (severity_ == LOG_ERROR_REPORT) {
« no previous file with comments | « no previous file | chrome/app/breakpad.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698