Preparser extracted into separate files that can be compiled to a library.

Preparser extracted into separate files that can be compiled to a library.
No scons target yet.

[fschneider, 2010-11-29 12:27:35]

LGTM.

http://codereview.chromium.org/5295004/diff/1/include/v8-preparser.h
File include/v8-preparser.h (right):

http://codereview.chromium.org/5295004/diff/1/include/v8-preparser.h#newcode75
include/v8-preparser.h:75: static PreParserData StackOverflow() { return
PreParserData(NULL, 0); }
For readability I'd insert new-lines here and after the other declarations.

http://codereview.chromium.org/5295004/diff/1/src/preparser.h
File src/preparser.h (right):

http://codereview.chromium.org/5295004/diff/1/src/preparser.h#newcode83
src/preparser.h:83: PreParser() : scope_(NULL), allow_lazy_(true) { }
stack_limit_ and stack_overflow_ should be initialized here?

[Lasse Reichstein, 2010-11-29 13:06:39]

http://codereview.chromium.org/5295004/diff/1/include/v8-preparser.h
File include/v8-preparser.h (right):

http://codereview.chromium.org/5295004/diff/1/include/v8-preparser.h#newcode75
include/v8-preparser.h:75: static PreParserData StackOverflow() { return
PreParserData(NULL, 0); }
More whitespacing inserted.

http://codereview.chromium.org/5295004/diff/1/src/preparser.h
File src/preparser.h (right):

http://codereview.chromium.org/5295004/diff/1/src/preparser.h#newcode83
src/preparser.h:83: PreParser() : scope_(NULL), allow_lazy_(true) { }
Not really. In fact, allow_lazy_ shouldn't be initialized either, since it's
initialized before use in PerParseProgram.

However, this pattern of usage sucks.
I should make the constructor private, have it initialize the variables, and
make PreParseProgram static. I'll do that.
And while I'm at it, I think I can move the internally used types into the class
as well.