Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3875)

Unified Diff: chrome/browser/chromeos/login/login_screen.cc

Issue 5287003: Add user metrics for the login screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/chrome/tools
Patch Set: Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/tools/chromeactions.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/login_screen.cc
diff --git a/chrome/browser/chromeos/login/login_screen.cc b/chrome/browser/chromeos/login/login_screen.cc
index 0efde849e28b6925035d7d10ff54ec3a3d1f4cea..4ec6306e800adc8342ff323e7b58743c3ca7197f 100644
--- a/chrome/browser/chromeos/login/login_screen.cc
+++ b/chrome/browser/chromeos/login/login_screen.cc
@@ -77,6 +77,8 @@ void LoginScreen::ClearErrors() {
}
void LoginScreen::OnLoginFailure(const LoginFailure& failure) {
+ UserMetrics::RecordAction(UserMetricsAction("LoginScreen_LoginFailure"));
Nikita (slow) 2010/11/29 10:59:06 I think it's better to track error codes here as w
satorux1 2010/12/02 10:41:46 Good idea, done.
+
const std::string error = failure.GetErrorString();
VLOG(1) << "LoginManagerView: OnLoginFailure() " << error;
NetworkLibrary* network = CrosLibrary::Get()->GetNetworkLibrary();
@@ -99,6 +101,7 @@ void LoginScreen::OnLoginSuccess(
const std::string& password,
const GaiaAuthConsumer::ClientLoginResult& credentials,
bool pending_requests) {
+ UserMetrics::RecordAction(UserMetricsAction("LoginScreen_LoginSuccess"));
delegate()->GetObserver(this)->OnExit(ScreenObserver::LOGIN_SIGN_IN_SELECTED);
AppendStartUrlToCmdline();
@@ -106,6 +109,9 @@ void LoginScreen::OnLoginSuccess(
}
void LoginScreen::OnOffTheRecordLoginSuccess() {
+ UserMetrics::RecordAction(
+ UserMetricsAction("LoginScreen_OffTheRecordLoginSuccess"));
+
LoginUtils::Get()->CompleteOffTheRecordLogin(start_url_);
}
« no previous file with comments | « no previous file | chrome/tools/chromeactions.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698