Add user metrics for the login screen.

chrome/browser/chromeos/login/login_screen.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/login_screen.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/callback.h"
 #include "base/command_line.h"
@@ skipping 59 matching lines @@
   delegate()->GetObserver(this)->OnExit(ScreenObserver::LOGIN_CREATE_ACCOUNT);
 }
 
 void LoginScreen::ClearErrors() {
   // bubble_ will be set to NULL in InfoBubbleClosing callback.
   if (bubble_)
     bubble_->Close();
 }
 
 void LoginScreen::OnLoginFailure(const LoginFailure& failure) {
+  UserMetrics::RecordAction(UserMetricsAction("LoginScreen_LoginFailure"));

[Nikita (slow), 2010/11/29 10:59:06]

I think it's better to track error codes here as well.
See histogram Net.ErrorCodesForMainFrame for instance.

[satorux1, 2010/12/02 10:41:46]

Good idea, done.

+
   const std::string error = failure.GetErrorString();
   VLOG(1) << "LoginManagerView: OnLoginFailure() " << error;
   NetworkLibrary* network = CrosLibrary::Get()->GetNetworkLibrary();
 
   // Check networking after trying to login in case user is
   // cached locally or the local admin account.
   if (!network || !CrosLibrary::Get()->EnsureLoaded()) {
     ShowError(IDS_LOGIN_ERROR_NO_NETWORK_LIBRARY, error);
   } else if (!network->Connected()) {
     ShowError(IDS_LOGIN_ERROR_OFFLINE_FAILED_NETWORK_NOT_CONNECTED, error);
   } else {
     ShowError(IDS_LOGIN_ERROR_AUTHENTICATING_NEW, error);
   }
 
   view()->ClearAndEnablePassword();
 }
 
 void LoginScreen::OnLoginSuccess(
     const std::string& username,
     const std::string& password,
     const GaiaAuthConsumer::ClientLoginResult& credentials,
     bool pending_requests) {
+  UserMetrics::RecordAction(UserMetricsAction("LoginScreen_LoginSuccess"));
 
   delegate()->GetObserver(this)->OnExit(ScreenObserver::LOGIN_SIGN_IN_SELECTED);
   AppendStartUrlToCmdline();
   LoginUtils::Get()->CompleteLogin(username, password, credentials);
 }
 
 void LoginScreen::OnOffTheRecordLoginSuccess() {
+  UserMetrics::RecordAction(
+      UserMetricsAction("LoginScreen_OffTheRecordLoginSuccess"));
+
   LoginUtils::Get()->CompleteOffTheRecordLogin(start_url_);
 }
 
 void LoginScreen::OnHelpLinkActivated() {
   AddStartUrl(GetAccountRecoveryHelpUrl());
   OnLoginOffTheRecord();
 }
 
 void LoginScreen::AppendStartUrlToCmdline() {
   if (start_url_.is_valid())
@@ skipping 11 matching lines @@
       view()->GetWidget(),
       view()->GetPasswordBounds(),
       BubbleBorder::LEFT_TOP,
       ResourceBundle::GetSharedInstance().GetBitmapNamed(IDR_WARNING),
       error_text,
       l10n_util::GetString(IDS_CANT_ACCESS_ACCOUNT_BUTTON),
       this);
 }
 
 }  // namespace chromeos