Issue 528002: Widen Mac intl1 and intl2 expectations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 528002: Widen Mac intl1 and intl2 expectations. (Closed)

Created:
10 years, 11 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org

Visibility:
Public.

Description

Widen Mac intl1 and intl2 expectations. There are many false positive alerts for these tests. Reduce them by widening the expected variance. BUG=none TEST=mac perf tests stay green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35812

Patch Set 1 #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/perf_expectations/perf_expectations.json	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nicolas Sylvain

10 years, 11 months ago (2010-01-08 19:31:00 UTC) #2

LGTM

On Fri, Jan 8, 2010 at 11:26 AM, <chase@chromium.org> wrote:

> Reviewers: Nicolas Sylvain,
>
> Description:
> Widen Mac intl1 and intl2 expectations.
>
> There are many false positive alerts for these tests.
> Reduce them by widening the expected variance.
>
> BUG=none
> TEST=mac perf tests stay green
>
> Please review this at http://codereview.chromium.org/528002
>
> Affected files:
>  M tools/perf_expectations/perf_expectations.json
>
>
> Index: tools/perf_expectations/perf_expectations.json
> diff --git a/tools/perf_expectations/perf_expectations.json
> b/tools/perf_expectations/perf_expectations.json
> index
>
c342db37d88914bd52e4476ff87241a3c4b2a838..1869823c5cf9ae3f1667a154140e71a4d7969849
> 100644
> --- a/tools/perf_expectations/perf_expectations.json
> +++ b/tools/perf_expectations/perf_expectations.json
> @@ -11,8 +11,8 @@
>  "linux-release-hardy/moz/times/t": {"delta": 0, "var": 6},
>  "linux-release-hardy/startup/warm/t": {"delta": 0, "var": 20},
>  "mac-release-10.5/dhtml/times/t": {"delta": 0, "var": 60},
> - "mac-release-10.5/intl1/times/t": {"delta": 0, "var": 100},
> - "mac-release-10.5/intl2/times/t": {"delta": 0, "var": 100},
> + "mac-release-10.5/intl1/times/t": {"delta": 0, "var": 120},
> + "mac-release-10.5/intl2/times/t": {"delta": 0, "var": 120},
>  "mac-release-10.5/morejs/times/t": {"delta": 0, "var": 80},
>  "mac-release-10.5/moz/times/t": {"delta": 80, "var": 80},
>  "mac-release-10.5/startup/warm/t": {"delta": 0, "var": 20},
>
>
>

Expand Messages | Collapse Messages