Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 527003: Revert 35602 - Add a "minimum_chrome_version" key to the manifest.... (Closed)

Created:
10 years, 11 months ago by arv (Not doing code reviews)
Modified:
9 years, 4 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 35602 - Add a "minimum_chrome_version" key to the manifest. Broke unit_test on Mac10.5 Tests (dbg)(1) BUG=24737 Review URL: http://codereview.chromium.org/521036 TBR=aa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -94 lines) Patch
M chrome/app/chrome_dll_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/extensions/extension.cc View 3 chunks +0 lines, -43 lines 0 comments Download
M chrome/common/extensions/extension_constants.h View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_constants.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 3 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
arv (Not doing code reviews)
10 years, 11 months ago (2010-01-06 02:41:37 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698