On windows filepaths need \\?\ prefix to allow extended file path names. Fix ...

webkit/fileapi/file_system_operation_unittest.cc

Index: webkit/fileapi/file_system_operation_unittest.cc
===================================================================
--- webkit/fileapi/file_system_operation_unittest.cc	(revision 67172)
+++ webkit/fileapi/file_system_operation_unittest.cc	(working copy)
@@ -463,6 +463,34 @@
   EXPECT_EQ(request_id_, mock_dispatcher_->request_id());
 }
 
+TEST_F(FileSystemOperationTest, TestCreateVeryLongName) {
+  ScopedTempDir dir;
+  ASSERT_TRUE(dir.CreateUniqueTempDir());
+
+#if defined(OS_WIN)
+  FilePath dir_path(FILE_PATH_LITERAL("\\\\?\\") + dir.path().value());
+#elif
+  FilePath dir_path = dir.path();
+#endif
+
+  // TODO(kkanetkar): Once each platform's limitations have been enforced
+  // separate out platform specific tests. Currently this test is for
+  // windows primarily.

[ericu, 2010/11/25 04:37:27]

I feel like what we should really be doing is running the same test on all
platforms, and getting the same result.  At some point in the code, there should
be an API that just does the right thing for us without us having to know what
platform it is.  We should run tests at that level.

There's nothing wrong with this code, but the comment feels wrong to me.

+  FilePath dir1 = dir_path.AppendASCII(
+      "012345678901234567890123456789012345678901234567890123456789"
+      "012345678901234567890123456789012345678901234567890123456789"
+      "0123456789012345678901234567890123456789");
+  FilePath file = dir1.AppendASCII(
+      "012345678901234567890123456789012345678901234567890123456789"
+      "012345678901234567890123456789012345678901234567890123456789"
+      "0123456789012345678901234567890123456789");
+  operation()->CreateDirectory(dir1, false, true);
+  MessageLoop::current()->RunAllPending();
+  operation()->CreateFile(file, true);
+  MessageLoop::current()->RunAllPending();
+  EXPECT_TRUE(file_util::PathExists(file));
+}
+
 TEST_F(FileSystemOperationTest, TestCreateFileSuccessFileExists) {
   // Already existing file and exclusive false.
   ScopedTempDir dir;