On windows filepaths need \\?\ prefix to allow extended file path names. Fix ...

webkit/fileapi/file_system_operation_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/fileapi/file_system_operation.h"
 
 #include "base/logging.h"
 #include "base/message_loop.h"
 #include "base/scoped_ptr.h"
 #include "base/scoped_temp_dir.h"
@@ skipping 445 matching lines @@
   ASSERT_TRUE(dir.CreateUniqueTempDir());
   FilePath file;
 
   file_util::CreateTemporaryFileInDir(dir.path(), &file);
   operation()->CreateFile(file, true);
   MessageLoop::current()->RunAllPending();
   EXPECT_EQ(base::PLATFORM_FILE_ERROR_EXISTS, mock_dispatcher_->status());
   EXPECT_EQ(request_id_, mock_dispatcher_->request_id());
 }
 
+TEST_F(FileSystemOperationTest, TestCreateVeryLongName) {
+  ScopedTempDir dir;
+  ASSERT_TRUE(dir.CreateUniqueTempDir());
+
+#if defined(OS_WIN)
+  FilePath dir_path(FILE_PATH_LITERAL("\\\\?\\") + dir.path().value());
+#elif
+  FilePath dir_path = dir.path();
+#endif
+
+  // TODO(kkanetkar): Once each platform's limitations have been enforced
+  // separate out platform specific tests. Currently this test is for
+  // windows primarily.

[ericu, 2010/11/25 04:37:27]

I feel like what we should really be doing is running the same test on all
platforms, and getting the same result.  At some point in the code, there should
be an API that just does the right thing for us without us having to know what
platform it is.  We should run tests at that level.

There's nothing wrong with this code, but the comment feels wrong to me.

+  FilePath dir1 = dir_path.AppendASCII(
+      "012345678901234567890123456789012345678901234567890123456789"
+      "012345678901234567890123456789012345678901234567890123456789"
+      "0123456789012345678901234567890123456789");
+  FilePath file = dir1.AppendASCII(
+      "012345678901234567890123456789012345678901234567890123456789"
+      "012345678901234567890123456789012345678901234567890123456789"
+      "0123456789012345678901234567890123456789");
+  operation()->CreateDirectory(dir1, false, true);
+  MessageLoop::current()->RunAllPending();
+  operation()->CreateFile(file, true);
+  MessageLoop::current()->RunAllPending();
+  EXPECT_TRUE(file_util::PathExists(file));
+}
+
 TEST_F(FileSystemOperationTest, TestCreateFileSuccessFileExists) {
   // Already existing file and exclusive false.
   ScopedTempDir dir;
   ASSERT_TRUE(dir.CreateUniqueTempDir());
   FilePath file;
   file_util::CreateTemporaryFileInDir(dir.path(), &file);
 
   operation()->CreateFile(file, false);
   MessageLoop::current()->RunAllPending();
   EXPECT_EQ(kFileOperationSucceeded, mock_dispatcher_->status());
@@ skipping 305 matching lines @@
 
   // Check that its length is now 3 and that it contains only bits of test data.
   EXPECT_TRUE(file_util::GetFileInfo(file, &info));
   EXPECT_EQ(length, info.size);
   EXPECT_EQ(length, file_util::ReadFile(file, data, length));
   for (int i = 0; i < length; ++i)
     EXPECT_EQ(test_data[i], data[i]);
 }
 
 }  // namespace fileapi