Issue 5257002: Increment tries so it doesn't loop forever.

Issue 5257002: Increment tries so it doesn't loop forever. (Closed)

Created:
10 years, 1 month ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, nsylvain

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Increment tries so it doesn't loop forever. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=67359

Patch Set 2 : previous commit was wrong, integrate change #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	third_party/upload.py	View	1	2 chunks	+2 lines, -1 line	2 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

Updated http://codereview.appspot.com/3227041/ accordingly.

10 years, 1 month ago (2010-11-23 02:02:19 UTC) #1

M-A Ruel

Updated http://codereview.appspot.com/3227041/ accordingly. (John is on vacation)

10 years, 1 month ago (2010-11-24 20:00:43 UTC) #2

nsylvain

http://codereview.chromium.org/5257002/diff/3001/third_party/upload.py File third_party/upload.py (right): http://codereview.chromium.org/5257002/diff/3001/third_party/upload.py#newcode191 third_party/upload.py:191: assert re.match(r'^[a-z]+://[a-z0-9\.-_]+(|:[0-9]+)$', self.host), ( i dont know what this ...

10 years, 1 month ago (2010-11-24 21:56:30 UTC) #4

M-A Ruel

10 years, 1 month ago (2010-11-24 22:00:25 UTC) #5

nsylvain

10 years, 1 month ago (2010-11-24 22:06:08 UTC) #6

LGTM

On Wed, Nov 24, 2010 at 2:00 PM, <maruel@chromium.org> wrote:

>
> http://codereview.chromium.org/5257002/diff/3001/third_party/upload.py
> File third_party/upload.py (right):
>
>
>
http://codereview.chromium.org/5257002/diff/3001/third_party/upload.py#newcod...
> third_party/upload.py:191: assert
> re.match(r'^[a-z]+://[a-z0-9\.-_]+(|:[0-9]+)$', self.host), (
> On 2010/11/24 21:56:30, nsylvain wrote:
>
>> i dont know what this change means
>>
>
> I doesn't force the host to finish with a letter, e.g. numeric host ip
>
>
> http://codereview.chromium.org/5257002/
>

Expand Messages | Collapse Messages