Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/upload.py

Issue 5257002: Increment tries so it doesn't loop forever. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: previous commit was wrong, integrate change Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/upload.py
diff --git a/third_party/upload.py b/third_party/upload.py
old mode 100644
new mode 100755
index c532cd815e118d78187c1c85ffc378c12cd60c23..7a024cf432500112434d046dc53457b1796feeba
--- a/third_party/upload.py
+++ b/third_party/upload.py
@@ -188,7 +188,7 @@ class AbstractRpcServer(object):
if (not self.host.startswith("http://") and
not self.host.startswith("https://")):
self.host = "http://" + self.host
- assert re.match(r'^[a-z]+://[a-z0-9\.-_]+[a-z](|:[0-9]+)$', self.host), (
+ assert re.match(r'^[a-z]+://[a-z0-9\.-_]+(|:[0-9]+)$', self.host), (
nsylvain 2010/11/24 21:56:30 i dont know what this change means
M-A Ruel 2010/11/24 22:00:26 I doesn't force the host to finish with a letter,
'%s is malformed' % host)
self.host_override = host_override
self.auth_function = auth_function
@@ -280,6 +280,7 @@ class AbstractRpcServer(object):
tries = 0
url = "%s/_ah/login?%s" % (host, urllib.urlencode(args))
while tries < 3:
+ tries += 1
req = self._CreateRequest(url)
try:
response = self.opener.open(req)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698