Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 525363002: Fix Date DST computation. (Closed)

Created:
6 years, 3 months ago by ulan
Modified:
6 years, 3 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/date.h View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ulan
PTAL
6 years, 3 months ago (2014-09-01 13:23:22 UTC) #2
rossberg
LGTM Maybe add regression test?
6 years, 3 months ago (2014-09-01 13:56:20 UTC) #3
ulan
On 2014/09/01 13:56:20, rossberg wrote: > LGTM > > Maybe add regression test? I thought ...
6 years, 3 months ago (2014-09-01 14:02:55 UTC) #4
rossberg
On 2014/09/01 14:02:55, ulan wrote: > On 2014/09/01 13:56:20, rossberg wrote: > > LGTM > ...
6 years, 3 months ago (2014-09-01 14:39:31 UTC) #5
ulan
6 years, 3 months ago (2014-09-02 11:54:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698