Issue 5242002: Reland 66791 (change was innocent)...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5242002: Reland 66791 (change was innocent)... (Closed)

Created:
10 years, 1 month ago by willchan no longer on Chromium

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Reland 66791 (change was innocent) Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread. Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/5206005 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66808

Patch Set 1 #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+258 lines, -100 lines)			Patch
M	base/lazy_instance.h	View	4 chunks	+10 lines, -1 line	0 comments	Download
M	base/message_loop_proxy_impl.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	base/platform_thread_posix.cc	View	3 chunks	+26 lines, -7 lines	0 comments	Download
M	base/platform_thread_win.cc	View	3 chunks	+52 lines, -22 lines	0 comments	Download
M	base/singleton.h	View	5 chunks	+11 lines, -0 lines	0 comments	Download
M	base/thread_restrictions.h	View	3 chunks	+32 lines, -3 lines	0 comments	Download
M	base/thread_restrictions.cc	View	2 chunks	+21 lines, -2 lines	0 comments	Download
M	base/tracked_objects.cc	View	4 chunks	+22 lines, -5 lines	0 comments	Download
M	ceee/ie/broker/executors_manager.h	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	chrome/browser/browser_thread.cc	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	net/base/dns_reload_timer.cc	View	3 chunks	+12 lines, -4 lines	0 comments	Download
M	net/base/ev_root_ca_metadata.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	net/base/ev_root_ca_metadata.cc	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	net/base/keygen_handler_unittest.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	net/base/x509_certificate.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/base/x509_certificate.cc	View	10 chunks	+26 lines, -28 lines	0 comments	Download
M	net/base/x509_certificate_mac.cc	View	6 chunks	+12 lines, -7 lines	0 comments	Download
M	net/ocsp/nss_ocsp.cc	View	9 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages