Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 5206005: Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread.... (Closed)

Created:
10 years, 1 month ago by willchan no longer on Chromium
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Revert 66719 - Reland r65996. Disallows Singletons on non-joinable thread. Test breakages caused by this change have been fixed here or in other changelists. BUG=61753 TEST=none Review URL: http://codereview.chromium.org/5024003 TBR=willchan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -258 lines) Patch
M base/lazy_instance.h View 4 chunks +1 line, -10 lines 0 comments Download
M base/message_loop_proxy_impl.cc View 3 chunks +1 line, -6 lines 0 comments Download
M base/platform_thread_posix.cc View 3 chunks +7 lines, -26 lines 0 comments Download
M base/platform_thread_win.cc View 3 chunks +22 lines, -52 lines 0 comments Download
M base/singleton.h View 5 chunks +0 lines, -11 lines 0 comments Download
M base/thread_restrictions.h View 3 chunks +3 lines, -32 lines 0 comments Download
M base/thread_restrictions.cc View 2 chunks +2 lines, -21 lines 0 comments Download
M base/tracked_objects.cc View 4 chunks +5 lines, -22 lines 0 comments Download
M ceee/ie/broker/executors_manager.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/browser_thread.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M net/base/dns_reload_timer.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M net/base/ev_root_ca_metadata.h View 2 chunks +2 lines, -4 lines 0 comments Download
M net/base/ev_root_ca_metadata.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M net/base/keygen_handler_unittest.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M net/base/x509_certificate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/x509_certificate.cc View 10 chunks +28 lines, -26 lines 0 comments Download
M net/base/x509_certificate_mac.cc View 6 chunks +7 lines, -12 lines 0 comments Download
M net/ocsp/nss_ocsp.cc View 9 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
willchan no longer on Chromium
10 years, 1 month ago (2010-11-19 19:17:01 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698