Allow using system libevent instead of the bundled one.

Allow using system libevent instead of the bundled one.

Patch by Bernard Cafarelli <voyageur@gentoo.org>;

TEST=none
BUG=22140
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35711

[Mark Mentovai, 2010-01-07 17:34:09]

LG otherwise.

http://codereview.chromium.org/524061/diff/1/8
File third_party/libevent/libevent.gyp (right):

http://codereview.chromium.org/524061/diff/1/8#newcode35
third_party/libevent/libevent.gyp:35: '.',   # libevent includes some of its own
headers with #include <...>
Reflow to avoid busting the 80-column limit.

http://codereview.chromium.org/524061/diff/1/8#newcode60
third_party/libevent/libevent.gyp:60: }, {
Put a #comment here so that we know that this is the else clause for
use_system_libevent.

[dank, 2010-01-07 17:36:15]

What Mark said :-)

[Paweł Hajdan Jr., 2010-01-07 17:48:35]

+agl

[agl, 2010-01-07 18:13:08]

LGTM.

From the header files etc it doesn't look like there's a good way to stop people
from building with a bad version of libevent. They only define a string and you
can't test strings in the preprocessor. I guess we just have to hope.

http://codereview.chromium.org/524061/diff/2004/4001
File AUTHORS (right):

http://codereview.chromium.org/524061/diff/2004/4001#newcode61
AUTHORS:61: Bernard Cafarelli <voyageur@gentoo.org>
(I assume that he's actually signed the agreement)

[Mark Mentovai, 2010-01-07 18:58:07]

We could do a runtime check if we really cared...

Mark

agl wrote:
> LGTM.
>
> From the header files etc it doesn't look like there's a good way to stop
> people
> from building with a bad version of libevent. They only define a string and
> you
> can't test strings in the preprocessor. I guess we just have to hope.
>
>
> http://codereview.chromium.org/524061/diff/2004/4001
> File AUTHORS (right):
>
> http://codereview.chromium.org/524061/diff/2004/4001#newcode61
> AUTHORS:61: Bernard Cafarelli <voyageur@gentoo.org>
> (I assume that he's actually signed the agreement)
>
> http://codereview.chromium.org/524061
>