Add "diff against" support when sending try patches.

Add "diff against" support when sending try patches.

This is mostly useful with git when diffing against arbitrary branches.

[M-A Ruel, 2010-01-06 16:05:02]

That should restore functionality lost with r35219. Albeit the form is slightly
different and --webkit shorthand is still missing.

[M-A Ruel, 2010-01-07 01:44:20]

ping

[bradn, 2010-01-07 01:50:13]

LGTM

http://codereview.chromium.org/524046/diff/1/2
File scm.py (right):

http://codereview.chromium.org/524046/diff/1/2#newcode574
scm.py:574: if revision is not None:
if not revision:

[M-A Ruel, 2010-01-07 02:04:30]

On 2010/01/07 01:50:13, bradn wrote:
> http://codereview.chromium.org/524046/diff/1/2#newcode574
> scm.py:574: if revision is not None:
> if not revision:

I wanted to support revision = 0 but I guess it's a non-sense anyway.

[M-A Ruel, 2010-01-07 02:14:15]

On 2010/01/07 02:04:30, Marc-Antoine Ruel wrote:
> On 2010/01/07 01:50:13, bradn wrote:
> > http://codereview.chromium.org/524046/diff/1/2#newcode574
> > scm.py:574: if revision is not None:
> > if not revision:
> 
> I wanted to support revision = 0 but I guess it's a non-sense anyway.

BTW you meant "if revision:"

[bradn, 2010-01-07 02:34:25]

yeah good point, what you had was fine.

-BradN

On Wed, Jan 6, 2010 at 6:14 PM, <maruel@chromium.org> wrote:

> On 2010/01/07 02:04:30, Marc-Antoine Ruel wrote:
>
>> On 2010/01/07 01:50:13, bradn wrote:
>> > http://codereview.chromium.org/524046/diff/1/2#newcode574
>> > scm.py:574: if revision is not None:
>> > if not revision:
>>
>
>  I wanted to support revision = 0 but I guess it's a non-sense anyway.
>>
>
> BTW you meant "if revision:"
>
>
> http://codereview.chromium.org/524046
>