Issue 5234005: NTP: Fix context menu for apps in small and minimized mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5234005: NTP: Fix context menu for apps in small and minimized mode. (Closed)

Created:
10 years, 1 month ago by arv (Not doing code reviews)

Modified:
9 years, 4 months ago

Reviewers:
Aaron Boodman, Bons

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

NTP: Fix context menu for apps in small and minimized mode. BUG=63415 TEST=Install and App. Go to the NTP Right clicking on the app in expanded/small/minimized mode This should bring up a context menu in all cases. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66855

Patch Set 1 #

Patch Set 2 : Fix the menu items too #

Total comments: 2

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	chrome/browser/resources/new_new_tab.html	View		2 chunks	+5 lines, -5 lines	1 comment	Download
	M	chrome/browser/resources/ntp/apps.js	View	1	3 chunks	+11 lines, -8 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

http://codereview.chromium.org/5234005/diff/2001/chrome/browser/resources/new_new_tab.html File chrome/browser/resources/new_new_tab.html (right): http://codereview.chromium.org/5234005/diff/2001/chrome/browser/resources/new_new_tab.html#newcode247 chrome/browser/resources/new_new_tab.html:247: <menu id="app-context-menu"> The order was changed so that the ...

10 years, 1 month ago (2010-11-19 22:31:36 UTC) #1

LG™

Expand Messages | Collapse Messages