Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/new_new_tab.html

Issue 5234005: NTP: Fix context menu for apps in small and minimized mode. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix the menu items too Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/resources/ntp/apps.js » ('j') | chrome/browser/resources/ntp/apps.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html i18n-values=" 2 <html i18n-values="
3 dir:textdirection; 3 dir:textdirection;
4 bookmarkbarattached:bookmarkbarattached; 4 bookmarkbarattached:bookmarkbarattached;
5 hasattribution:hasattribution; 5 hasattribution:hasattribution;
6 anim:anim; 6 anim:anim;
7 syncispresent:syncispresent; 7 syncispresent:syncispresent;
8 customlogo:customlogo" 8 customlogo:customlogo"
9 install-animation-enabled="true"> 9 install-animation-enabled="true">
10 <head> 10 <head>
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 <command id="apps-launch-command"> 232 <command id="apps-launch-command">
233 <command id="apps-options-command" i18n-values=".label:appoptions"> 233 <command id="apps-options-command" i18n-values=".label:appoptions">
234 <command id="apps-uninstall-command" i18n-values=".label:appuninstall"> 234 <command id="apps-uninstall-command" i18n-values=".label:appuninstall">
235 <command id="apps-launch-type-pinned" i18n-values=".label:applaunchtypepinned" 235 <command id="apps-launch-type-pinned" i18n-values=".label:applaunchtypepinned"
236 launch-type="0"> 236 launch-type="0">
237 <command id="apps-launch-type-regular" i18n-values=".label:applaunchtyperegular" 237 <command id="apps-launch-type-regular" i18n-values=".label:applaunchtyperegular"
238 launch-type="1"> 238 launch-type="1">
239 <command id="apps-launch-type-fullscreen" 239 <command id="apps-launch-type-fullscreen"
240 i18n-values=".label:applaunchtypefullscreen" launch-type="2"> 240 i18n-values=".label:applaunchtypefullscreen" launch-type="2">
241 241
242 <!-- These are populated dynamically -->
243 <menu id="apps-menu"></menu>
244 <menu id="most-visited-menu"></menu>
245 <menu id="recently-closed-menu"></menu>
246
242 <menu id="app-context-menu"> 247 <menu id="app-context-menu">
arv (Not doing code reviews) 2010/11/19 22:31:36 The order was changed so that the context menu is
243 <button class="default" command="#apps-launch-command"></button> 248 <button class="default" command="#apps-launch-command"></button>
244 <hr> 249 <hr>
245 <button command="#apps-launch-type-regular" launch-type="1"></button> 250 <button command="#apps-launch-type-regular" launch-type="1"></button>
246 <button command="#apps-launch-type-pinned" launch-type="0"></button> 251 <button command="#apps-launch-type-pinned" launch-type="0"></button>
247 <button command="#apps-launch-type-fullscreen" launch-type="2"></button> 252 <button command="#apps-launch-type-fullscreen" launch-type="2"></button>
248 <hr> 253 <hr>
249 <button command="#apps-options-command"></button> 254 <button command="#apps-options-command"></button>
250 <button command="#apps-uninstall-command"></button> 255 <button command="#apps-uninstall-command"></button>
251 </menu> 256 </menu>
252 257
253 <!-- These are populated dynamically -->
254 <menu id="apps-menu"></menu>
255 <menu id="most-visited-menu"></menu>
256 <menu id="recently-closed-menu"></menu>
257
258 </body> 258 </body>
259 259
260 <script src="shared/js/i18n_template.js"></script> 260 <script src="shared/js/i18n_template.js"></script>
261 <script> 261 <script>
262 i18nTemplate.process(document, templateData); 262 i18nTemplate.process(document, templateData);
263 </script> 263 </script>
264 <script src="shared/js/local_strings.js"></script> 264 <script src="shared/js/local_strings.js"></script>
265 <script src="shared/js/parse_html_subset.js"></script> 265 <script src="shared/js/parse_html_subset.js"></script>
266 266
267 <script src="shared/js/cr.js"></script> 267 <script src="shared/js/cr.js"></script>
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 setSectionVisible('apps', Section.APPS, appsInitiallyVisible, MINIMIZED_APPS); 305 setSectionVisible('apps', Section.APPS, appsInitiallyVisible, MINIMIZED_APPS);
306 setSectionVisible( 306 setSectionVisible(
307 'most-visited', Section.THUMB, 307 'most-visited', Section.THUMB,
308 mostVisitedInitiallyVisible, MINIMIZED_THUMB); 308 mostVisitedInitiallyVisible, MINIMIZED_THUMB);
309 setSectionVisible( 309 setSectionVisible(
310 'recently-closed', undefined, 310 'recently-closed', undefined,
311 recentlyClosedInitiallyVisible, MINIMIZED_RECENT); 311 recentlyClosedInitiallyVisible, MINIMIZED_RECENT);
312 layoutSections(); 312 layoutSections();
313 </script> 313 </script>
314 </html> 314 </html>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/ntp/apps.js » ('j') | chrome/browser/resources/ntp/apps.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698